[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30
From: |
Kevin Wolf |
Subject: |
Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30 |
Date: |
Fri, 20 Nov 2020 17:36:27 +0100 |
Am 20.11.2020 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> As Peter recently noted, iotest 30 accidentally fails.
>
> I found that Qemu crashes due to interleaving of graph-update
> operations of parallel mirror and stream block-jobs.
I haven't found the time yet to properly look into this or your other
thread where you had a similar question, but there is one thing I'm
wondering: Why can the nested job even make progress and run its
completion handler?
When we modify the graph, we should have drained the subtree in
question, so in theory while one job finishes and modifies the graph,
there should be no way for the other job to make progress and get
interleaved - it shouldn't be able to start I/O requests and much less
to run its completion handler and modify the graph.
Are we missing drained sections somewhere or do they fail to achieve
what I think they should achieve?
Kevin
- [PATCH RFC 0/5] Fix accidental crash in iotest 30, Vladimir Sementsov-Ogievskiy, 2020/11/20
- [PATCH 1/5] abort-on-set-to-true, Vladimir Sementsov-Ogievskiy, 2020/11/20
- [PATCH 2/5] iotest-30-shorten: concentrate on failing test case, Vladimir Sementsov-Ogievskiy, 2020/11/20
- [PATCH 3/5] scripts/block-coroutine-wrapper.py: allow more function types, Vladimir Sementsov-Ogievskiy, 2020/11/20
- [PATCH 4/5] block: move some mirror and stream handlers to coroutine, Vladimir Sementsov-Ogievskiy, 2020/11/20
- [PATCH 5/5] block: protect some graph-modifyng things by mutex, Vladimir Sementsov-Ogievskiy, 2020/11/20
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, no-reply, 2020/11/20
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30,
Kevin Wolf <=
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Vladimir Sementsov-Ogievskiy, 2020/11/20
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Kevin Wolf, 2020/11/20
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Vladimir Sementsov-Ogievskiy, 2020/11/20
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Kevin Wolf, 2020/11/23
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Vladimir Sementsov-Ogievskiy, 2020/11/23
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Kevin Wolf, 2020/11/23
- Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30, Vladimir Sementsov-Ogievskiy, 2020/11/23