Re: [PATCH 0/2] Clarify error messages pertaining to 'node-name'

[Connor Kuehl]

On 3/3/21 3:53 AM, Kevin Wolf wrote:
> Am 02.03.2021 um 00:36 hat Connor Kuehl geschrieben:
> > Some error messages contain ambiguous representations of the 'node-name'
> > parameter. This can be particularly confusing when exchanging QMP
> > messages (C = client, S = server):
> >
> > C: {"execute": "block_resize", "arguments": { "device": "my_file", "size": 
> > 26843545600 }}
> > S: {"error": {"class": "GenericError", "desc": "Cannot find device=my_file nor 
> > node_name="}}
> >                                                                                 
> > ^^^^^^^^^
>
> Arguably, this error message isn't great anyway because of the empty
> string node name. We didn't even look for a node name, so why mention it
> in the error message?
>
> But your patches are certainly a good improvement already. I would have
> merged them, but git grep 'nor node_name=' shows that you missed to
> update a few tests, so they fail after the series. I suppose you only
> caught the ones that are run by default in 'make check' and missed the
> ones that require running the qemu-iotests 'check' script manually.

Ah, good catch! Yes, I was only using `make check`, I'll use the `check` 
script to uncover the other failures and fix them accordingly.

> > [..]
>
> This is a good explanation for the change you're making. I think it
> deserves being committed to the repository in the commit message for
> patch 1.

I'll move this to patch #1 in the next revision of this series.

Thank you!

Connor