Re: [PULL v2 00/42] Block layer patches and object-add QAPIfication

[Stefan Hajnoczi]

On Tue, Mar 16, 2021 at 2:36 PM Kevin Wolf <kwolf@redhat.com> wrote:
>
> Am 16.03.2021 um 14:17 hat Peter Maydell geschrieben:
> > On Mon, 15 Mar 2021 at 12:35, Kevin Wolf <kwolf@redhat.com> wrote:
> > >
> > > The following changes since commit 
> > > 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
> > >
> > >   Merge remote-tracking branch 
> > > 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging 
> > > (2021-03-14 17:47:49 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
> > >
> > > for you to fetch changes up to 078ee48ef7d172df1b3ad020255d1eb6beda2daf:
> > >
> > >   qom: Support JSON in HMP object_add and tools --object (2021-03-15 
> > > 13:04:27 +0100)
> > >
> > > ----------------------------------------------------------------
> > > Block layer patches and object-add QAPIfication
> > >
> > > - QAPIfy object-add and --object for tools (keyval and JSON support)
> > > - Add vhost-user-blk-test
> > > - stream: Fail gracefully if permission is denied
> > > - storage-daemon: Fix crash on quit when job is still running
> > > - curl: Fix use after free
> > > - char: Deprecate backend aliases, fix QMP query-chardev-backends
> > > - Fix image creation option defaults that exist in both the format and
> > >   the protocol layer (e.g. 'cluster_size' in qcow2 and rbd; the qcow2
> > >   default was incorrectly applied to the rbd layer)
> > >
> > > ----------------------------------------------------------------
> >
> > Fails 'make check' on x86-64 linux:
> >
> > PASS 61 qtest-x86_64/qos-test
> > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-blk-pci/virtio-blk/virtio-blk-tests/config
> > PASS 62 qtest-x86_64/qos-test
> > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-blk-pci/virtio-blk/virtio-blk-tests/basic
> > PASS 63 qtest-x86_64/qos-test
> > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-blk-pci/virtio-blk/virtio-blk-tests/resize
> > **
> > ERROR:../../tests/qtest/libqos/virtio.c:194:qvirtio_wait_status_byte_no_isr:
> > assertion failed: (!d->bus->get_queue_isr_status(d, vq))
> > ERROR qtest-x86_64/qos-test - Bail out!
> > ERROR:../../tests/qtest/libqos/virtio.c:194:qvirtio_wait_status_byte_no_isr:
> > assertion failed: (!d->bus->get_queue_isr_status(d, vq))
> > Makefile.mtest:1008: recipe for target 'run-test-124' failed
> > make: *** [run-test-124] Error 1
>
> It didn't fail to me, so the condition must be a little more specific
> than just x86_64 Linux.
>
> Stefan, can you have a look? I may have to drop these patches again.

This issue is related to the vhost-user-blk test case and the patches
can be dropped.

Stefan