qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] hw/ide/via: Replace magic 2 value by ARRAY_SIZE / MAX_ID


From: John Snow
Subject: Re: [PATCH 4/6] hw/ide/via: Replace magic 2 value by ARRAY_SIZE / MAX_IDE_DEVS
Date: Thu, 25 Mar 2021 12:18:48 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 3/24/21 1:54 PM, Philippe Mathieu-Daudé wrote:
+    for (i = 0; i < ARRAY_SIZE(d->bus); i++) {
+        ide_bus_new(&d->bus[i], sizeof(d->bus[i]), ds, i, MAX_IDE_DEVS);

I bet nothing good happens if this value is ever not 2, but I bet that's no worse than the current reality. :)

ACK




reply via email to

[Prev in Thread] Current Thread [Next in Thread]