Re: [PATCH] ui/cocoa: Do not alert even without block devices

[Philippe Mathieu-Daudé]

On 13/2/22 03:14, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>   ui/cocoa.m | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index ac18e14ce01..271a2676026 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -1715,11 +1715,6 @@ static void addRemovableDevicesMenuItems(void)
>   
>       currentDevice = qmp_query_block(NULL);
>       pointerToFree = currentDevice;
> -    if(currentDevice == NULL) {
> -        NSBeep();
> -        QEMU_Alert(@"Failed to query for block devices!");
> -        return;
> -    }
>   
>       menu = [[[NSApp mainMenu] itemWithTitle:@"Machine"] submenu];
>   

Cc'ing qemu-block@ and Markus (QMP).

I always wondered the point of this annoying warning but never
found out.

Is this menu updated when removable blkdev are hot-plugged from
the monitor or QMP?

Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>