[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/26] block: add missing coroutine_fn annotations
From: |
Eric Blake |
Subject: |
Re: [PATCH 07/26] block: add missing coroutine_fn annotations |
Date: |
Tue, 19 Apr 2022 13:50:41 -0500 |
User-agent: |
NeoMutt/20211029-35-db88c3 |
On Fri, Apr 15, 2022 at 03:18:41PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/block-backend.c | 18 +++++++++---------
> block/io.c | 24 ++++++++++++------------
> 2 files changed, 21 insertions(+), 21 deletions(-)
>
> @@ -1580,8 +1580,8 @@ int blk_pread(BlockBackend *blk, int64_t offset, void
> *buf, int bytes)
> return ret < 0 ? ret : bytes;
> }
>
> -int blk_pwrite(BlockBackend *blk, int64_t offset, const void *buf, int bytes,
> - BdrvRequestFlags flags)
> +int coroutine_fn blk_pwrite(BlockBackend *blk, int64_t offset, const void
> *buf, int bytes,
> + BdrvRequestFlags flags)
Long line, worth rewrapping differently?
The functions with _co_ in the name are obvious, the others might be
worth a comment why it is okay.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 02/26] qcow2: remove incorrect coroutine_fn annotations, (continued)
[PATCH 04/26] coroutine: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/04/15
[PATCH 03/26] nbd: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/04/15
[PATCH 07/26] block: add missing coroutine_fn annotations, Paolo Bonzini, 2022/04/15
- Re: [PATCH 07/26] block: add missing coroutine_fn annotations,
Eric Blake <=
[PATCH 06/26] blkverify: add missing coroutine_fn annotations, Paolo Bonzini, 2022/04/15
[PATCH 05/26] blkdebug: add missing coroutine_fn annotations, Paolo Bonzini, 2022/04/15
[PATCH 08/26] file-posix: add missing coroutine_fn annotations, Paolo Bonzini, 2022/04/15
[PATCH 09/26] iscsi: add missing coroutine_fn annotations, Paolo Bonzini, 2022/04/15
[PATCH 11/26] nfs: add missing coroutine_fn annotations, Paolo Bonzini, 2022/04/15