qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 04/10] crypto: Make block callbacks return 0 on success


From: Hanna Reitz
Subject: Re: [PATCH v5 04/10] crypto: Make block callbacks return 0 on success
Date: Mon, 4 Jul 2022 13:48:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 09.06.22 17:27, Alberto Faria wrote:
They currently return the value of their headerlen/buflen parameter on
success. Returning 0 instead makes it clear that short reads/writes are
not possible.

Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
  block/crypto.c                 | 52 +++++++++++++++++-----------------
  block/qcow2.c                  | 22 +++++++-------
  crypto/block-luks.c            |  8 +++---
  crypto/block.c                 |  6 ++--
  include/crypto/block.h         | 32 ++++++++++-----------
  tests/unit/test-crypto-block.c | 38 ++++++++++++-------------
  6 files changed, 79 insertions(+), 79 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]