qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v9 16/21] block_job_query: remove atomic read


From: Emanuele Giuseppe Esposito
Subject: [PATCH v9 16/21] block_job_query: remove atomic read
Date: Wed, 6 Jul 2022 16:15:28 -0400

Not sure what the atomic here was supposed to do, since job.busy
is protected by the job lock. Since the whole function
is called under job_mutex, just remove the atomic.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
 blockjob.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blockjob.c b/blockjob.c
index 0d120ed126..bbd297b583 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -341,7 +341,7 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error 
**errp)
     info = g_new0(BlockJobInfo, 1);
     info->type      = g_strdup(job_type_str(&job->job));
     info->device    = g_strdup(job->job.id);
-    info->busy      = qatomic_read(&job->job.busy);
+    info->busy      = job->job.busy;
     info->paused    = job->job.pause_count > 0;
     info->offset    = progress_current;
     info->len       = progress_total;
-- 
2.31.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]