[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/15] error-report: introduce "detailed" variable
From: |
marcandre . lureau |
Subject: |
[PATCH v2 02/15] error-report: introduce "detailed" variable |
Date: |
Tue, 12 Jul 2022 13:35:15 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Let's use a more explicit variable "detailed" instead of calling
monitor_cur() multiple times.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
util/error-report.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/util/error-report.c b/util/error-report.c
index 98f242b75bbf..893da10f19bc 100644
--- a/util/error-report.c
+++ b/util/error-report.c
@@ -195,16 +195,17 @@ real_time_iso8601(void)
*/
static void vreport(report_type type, const char *fmt, va_list ap)
{
+ bool detailed = !monitor_cur();
gchar *timestr;
- if (message_with_timestamp && !monitor_cur()) {
+ if (message_with_timestamp && detailed) {
timestr = real_time_iso8601();
error_printf("%s ", timestr);
g_free(timestr);
}
/* Only prepend guest name if -msg guest-name and -name guest=... are set
*/
- if (error_with_guestname && error_guest_name && !monitor_cur()) {
+ if (error_with_guestname && error_guest_name && detailed) {
error_printf("%s ", error_guest_name);
}
--
2.37.0.rc0
- [PATCH v2 00/15] Preliminary patches for subproject split, marcandre . lureau, 2022/07/12
- [PATCH v2 01/15] error-report: misc comment fix, marcandre . lureau, 2022/07/12
- [PATCH v2 02/15] error-report: introduce "detailed" variable,
marcandre . lureau <=
- [PATCH v2 03/15] error-report: simplify print_loc(), marcandre . lureau, 2022/07/12
- [PATCH v2 04/15] error-report: introduce overridable error_is_detailed(), marcandre . lureau, 2022/07/12
- [PATCH v2 05/15] stubs: remove needless error_vprintf_unless_qmp(), marcandre . lureau, 2022/07/12
- [PATCH v2 06/15] qapi: move QEMU-specific dispatch code in monitor, marcandre . lureau, 2022/07/12
- [PATCH v2 08/15] scripts/qapi: add required system includes to visitor, marcandre . lureau, 2022/07/12
- [PATCH v2 07/15] scripts/qapi-gen: add -i option, marcandre . lureau, 2022/07/12