[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/6] hw/nvme: fix example serial in documentation
From: |
Klaus Jensen |
Subject: |
[PULL 3/6] hw/nvme: fix example serial in documentation |
Date: |
Fri, 15 Jul 2022 10:43:37 +0200 |
From: Niklas Cassel <niklas.cassel@wdc.com>
The serial prop on the controller is actually describing the nvme
subsystem serial, which has to be identical for all controllers within
the same nvme subsystem.
This is enforced since commit a859eb9f8f64 ("hw/nvme: enforce common
serial per subsystem").
Fix the documentation, so that people copying the qemu command line
example won't get an error on qemu start.
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
docs/system/devices/nvme.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/system/devices/nvme.rst b/docs/system/devices/nvme.rst
index aba253304e46..30f841ef6222 100644
--- a/docs/system/devices/nvme.rst
+++ b/docs/system/devices/nvme.rst
@@ -104,8 +104,8 @@ multipath I/O.
.. code-block:: console
-device nvme-subsys,id=nvme-subsys-0,nqn=subsys0
- -device nvme,serial=a,subsys=nvme-subsys-0
- -device nvme,serial=b,subsys=nvme-subsys-0
+ -device nvme,serial=deadbeef,subsys=nvme-subsys-0
+ -device nvme,serial=deadbeef,subsys=nvme-subsys-0
This will create an NVM subsystem with two controllers. Having controllers
linked to an ``nvme-subsys`` device allows additional ``nvme-ns`` parameters:
--
2.36.1
- [PULL 0/6] hw/nvme updates, Klaus Jensen, 2022/07/15
- [PULL 1/6] hw/nvme: Implement shadow doorbell buffer support, Klaus Jensen, 2022/07/15
- [PULL 2/6] hw/nvme: Add trace events for shadow doorbell buffer, Klaus Jensen, 2022/07/15
- [PULL 3/6] hw/nvme: fix example serial in documentation,
Klaus Jensen <=
- [PULL 4/6] hw/nvme: force nvme-ns param 'shared' to false if no nvme-subsys node, Klaus Jensen, 2022/07/15
- [PULL 5/6] nvme: Fix misleading macro when mixed with ternary operator, Klaus Jensen, 2022/07/15
- [PULL 6/6] hw/nvme: Use ioeventfd to handle doorbell updates, Klaus Jensen, 2022/07/15
- Re: [PULL 0/6] hw/nvme updates, Peter Maydell, 2022/07/15