Re: [PATCH v4 00/12] Improve reliability of VM tests

[Thomas Huth]

On 08/07/2022 17.34, John Snow wrote:
> Note: patches 10-12 are included for testing simplicity, they shouldn't
> be merged. They will be included in a forthcoming block PR.
>
> V4:
>
> - Addressed concern by Marc-Andre in patch 01.
> - Squashed Ubuntu patches (rth)
>
> This patch series attempts to improve the reliability of several of the
> VM test targets. In particular, both CentOS 8 tests are non-functional
> because CentOS 8 was EOL at the beginning of this calendar year, with
> repositories and mirrors going offline.
>
> I also remove the ubuntu.i386 test because we no longer support Ubuntu
> 18.04 nor do we have explicit need of an i386 build test.
>
> After this series, I am able to successfully run every VM target on an
> x86_64 host, except:
>
> - ubuntu.aarch64: Hangs often during testing, see below.
> - centos.aarch64: Hangs often during testing, see below.
> - haiku.x86_64: Build failures not addressed by this series, see
>    https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg02103.html
>
> The unit tests that I see fail most often under aarch64 are:
>
> - virtio-net-failover: Seems to like to hang on openbsd
> - migration-test: Tends to hang under aarch64 tcg
>
> Future work (next version? next series?);
>
> - Try to get centos.aarch64 working reliably under TCG
> - Upgrade ubuntu.aarch64 to 20.04 after fixing centos.aarch64
> - Fix the Haiku build test, if possible.
> - Ensure I can reliably run and pass "make vm-build-all".
>    (Remove VMs from this recipe if necessary.)

Not sure whether it's related to your patches, but when testing these I just 
got an error while running 'vm-build-openbsd' :

    VM-BUILD openbsd
fatal: not a valid object name:
failed to archive qemu
Failed to prepare guest environment
Traceback (most recent call last):
  File "/home/thuth/devel/qemu/tests/vm/basevm.py", line 641, in main
    vm.add_source_dir(args.build_qemu)
  File "/home/thuth/devel/qemu/tests/vm/basevm.py", line 277, in add_source_dir
    stdout=self._stdout, stderr=self._stderr)
  File "/usr/lib64/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['./scripts/archive-source.sh', 
'/home/thuth/tmp/qemu-build/vm-test-rm_z92hq.tmp/data-44e42.tar']' returned 
non-zero exit status 1.

The error did not occur again when running the command again, though.

 Thomas