Re: [PATCH v10 03/21] job.c: API functions not used outside should be st

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 03/21] job.c: API functions not used outside should be st

From:	Kevin Wolf
Subject:	Re: [PATCH v10 03/21] job.c: API functions not used outside should be static
Date:	Fri, 29 Jul 2022 14:30:50 +0200

Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben:
> job_event_* functions can all be static, as they are not used
> outside job.c.
> 
> Same applies for job_txn_add_job().
> 
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v10 00/21] job: replace AioContext lock with job_mutex, Emanuele Giuseppe Esposito, 2022/07/25
- [PATCH v10 02/21] job.h: categorize fields in struct Job, Emanuele Giuseppe Esposito, 2022/07/25
  - Re: [PATCH v10 02/21] job.h: categorize fields in struct Job, Kevin Wolf, 2022/07/29
- [PATCH v10 04/21] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED, Emanuele Giuseppe Esposito, 2022/07/25
  - Re: [PATCH v10 04/21] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED, Kevin Wolf, 2022/07/29
- [PATCH v10 03/21] job.c: API functions not used outside should be static, Emanuele Giuseppe Esposito, 2022/07/25
  - Re: [PATCH v10 03/21] job.c: API functions not used outside should be static, Kevin Wolf <=
- [PATCH v10 01/21] job.c: make job_mutex and job_lock/unlock() public, Emanuele Giuseppe Esposito, 2022/07/25
- [PATCH v10 06/21] job: move and update comments from blockjob.c, Emanuele Giuseppe Esposito, 2022/07/25
- [PATCH v10 11/21] jobs: group together API calls under the same job lock, Emanuele Giuseppe Esposito, 2022/07/25
  - Re: [PATCH v10 11/21] jobs: group together API calls under the same job lock, Vladimir Sementsov-Ogievskiy, 2022/07/27
- [PATCH v10 07/21] blockjob: introduce block_job _locked() APIs, Emanuele Giuseppe Esposito, 2022/07/25
- [PATCH v10 08/21] jobs: add job lock in find_* functions, Emanuele Giuseppe Esposito, 2022/07/25
- [PATCH v10 09/21] jobs: use job locks also in the unit tests, Emanuele Giuseppe Esposito, 2022/07/25
  - Re: [PATCH v10 09/21] jobs: use job locks also in the unit tests, Vladimir Sementsov-Ogievskiy, 2022/07/27
- [PATCH v10 10/21] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU, Emanuele Giuseppe Esposito, 2022/07/25
- [PATCH v10 16/21] blockjob: rename notifier callbacks as _locked, Emanuele Giuseppe Esposito, 2022/07/25

Prev by Date: Re: [PATCH v10 02/21] job.h: categorize fields in struct Job
Next by Date: Re: [PATCH v10 04/21] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED
Previous by thread: [PATCH v10 03/21] job.c: API functions not used outside should be static
Next by thread: [PATCH v10 01/21] job.c: make job_mutex and job_lock/unlock() public
Index(es):
- Date
- Thread