[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] 9pfs: use GHashTable for fid table
From: |
Linus Heckemann |
Subject: |
Re: [PATCH v3] 9pfs: use GHashTable for fid table |
Date: |
Thu, 08 Sep 2022 18:10:28 +0200 |
(sorry for the dup @Greg, forgot to reply-all)
Greg Kurz <groug@kaod.org> writes:
>> > g_hash_table_steal_extended() [1] actually allows to do just that.
>>
>> g_hash_table_steal_extended unfortunately isn't available since it was
>> introduced in glib 2.58 and we're maintaining compatibility to 2.56.
>>
>
> Ha... this could be addressed through conditional compilation, e.g.:
It still won't compile, because we set GLIB_VERSION_MAX_ALLOWED in
glib-compat.h and it would require a compat wrapper as described
there. I think that's a bit much for this far more marginal performance
change. I'm happy to resubmit with the TODO comment though if you like?