Re: [PATCH 00/27] qapi: Elide redundant has_FOO in generated C

[Vladimir Sementsov-Ogievskiy]

On 9/15/22 23:42, Markus Armbruster wrote:
> In QAPI, absent optional members are distinct from any present value.
> We thus represent an optional schema member FOO as two C members: a
> FOO with the member's type, and a bool has_FOO.  Likewise for function
> arguments.
>
> However, the has_FOO is actually redundant for a pointer-valued FOO,
> which can be null only when has_FOO is false, i.e. has_FOO == !!FOO.
> Except for arrays, where we a null FOO can also be a present empty
> array.
>
> The redundant has_FOO are a nuisance to work with.  Improve the
> generator to elide them.
>
> PATCH 01+02 are trivial documentation cleanups.
>
> PATCH 03 tweaks an example in documentation so it'll show the change.
>
> PATCH 04 improves the code generator, but nerfs the change for the
> schema modules where handwritten code needs to be updated.
>
> PATCH 05-26 un-nerfs in reviewable chunks.  Their commit messages
> refer back to PATCH 04 for an explanation of the transformation.
> Please read that first.  Note that these patches combine the
> mechanical transformation with obvious, local follow-up
> simplifications.  If you want them separate for easier review, let me
> know.

[..]

>   98 files changed, 456 insertions(+), 674 deletions(-)

Good stats!

--
Best regards,
Vladimir