qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/9] target/loongarch/cpu: Remove unneeded include directive


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 6/9] target/loongarch/cpu: Remove unneeded include directive
Date: Tue, 20 Sep 2022 06:57:30 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 20/9/22 01:17, Bernhard Beschow wrote:
The cpu is used in both user and system emulation context while sysbus.h
is system-only. Remove it since it's not needed anyway. Furthermore, it
would cause a compile error in the next commit.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
  target/loongarch/cpu.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h
index dce999aaac..c9ed2cb3e7 100644
--- a/target/loongarch/cpu.h
+++ b/target/loongarch/cpu.h
@@ -13,7 +13,6 @@
  #include "hw/registerfields.h"
  #include "qemu/timer.h"
  #include "exec/memory.h"
-#include "hw/sysbus.h"
#define IOCSRF_TEMP 0
  #define IOCSRF_NODECNT          1

Renaming the subject as 'target: Remove unneeded "hw/sysbus.h" include directive' and fixing target/ppc/kvm.c:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]