qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 01/10] monitor: expose monitor_puts to rest of code


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v1 01/10] monitor: expose monitor_puts to rest of code
Date: Wed, 21 Sep 2022 19:34:07 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 21/9/22 18:07, Alex Bennée wrote:
This helps us construct strings elsewhere before echoing to the
monitor. It avoids having to jump through hoops like:

   monitor_printf(mon, "%s", s->str);

It will be useful in following patches but for now convert all
existing plain "%s" printfs to use the _puts api.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

---
v2
   - s/monitor_printf(mon, "%s"/monitor_puts(mon, /
---
  docs/devel/writing-monitor-commands.rst |  2 +-
  include/monitor/monitor.h               |  1 +
  monitor/monitor-internal.h              |  1 -
  block/monitor/block-hmp-cmds.c          | 10 +++++-----
  hw/misc/mos6522.c                       |  2 +-
  monitor/hmp-cmds.c                      |  8 ++++----
  monitor/hmp.c                           |  2 +-
  target/i386/helper.c                    |  2 +-
  8 files changed, 14 insertions(+), 14 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]