[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 20/39] tests/qtest: {ahci, ide}-test: Use relative path fo
|
From: |
John Snow |
|
Subject: |
Re: [PATCH v2 20/39] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32 |
|
Date: |
Fri, 23 Sep 2022 16:00:18 -0400 |
On Thu, Sep 22, 2022 at 4:03 PM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Tue, Sep 20, 2022 at 1:50 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> From: Bin Meng <bin.meng@windriver.com>
>>
>> These test cases uses "blkdebug:path/to/config:path/to/image" for
>> testing. On Windows, absolute file paths contain the delimiter ':'
>> which causes the blkdebug filename parser fail to parse filenames.
>>
>> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
>
> I don't have a much better solution to propose at this point (to actually use
> a temp directory), so:
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
I assume we can switch to using the node-based specifications instead
of -file=blkdebug:%s and just spell out the tree more meticulously,
either on the CLI or by switching to using QMP for the test. These
tests were written a long time ago.
--js
- [PATCH v2 08/39] block/vvfat: Unify the mkdir() call, (continued)
- [PATCH v2 08/39] block/vvfat: Unify the mkdir() call, Bin Meng, 2022/09/20
- [PATCH v2 07/39] tests: Avoid using hardcoded /tmp in test cases, Bin Meng, 2022/09/20
- [PATCH v2 03/39] block: Unify the get_tmp_filename() implementation, Bin Meng, 2022/09/20
- [PATCH v2 20/39] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32, Bin Meng, 2022/09/20
- [PATCH v2 23/39] tests/qtest: ide-test: Open file in binary mode, Bin Meng, 2022/09/20