Re: [PATCH v2 1/4] block: rename the bdrv_co_block_status static function

[Eric Blake]

On Thu, Jun 01, 2023 at 01:51:28PM +0200, Paolo Bonzini wrote:
> bdrv_block_status exists as a wrapper for bdrv_block_status_above,
> but the name of the (hypothetical) coroutine version, bdrv_co_block_status,
> is squatted by a random static function.  Rename it to bdrv_do_block_status.

bdrv_co_do_block_status

> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/io.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)

> @@ -2509,8 +2509,7 @@ bdrv_co_common_block_status_above(BlockDriverState *bs,
>      for (p = bdrv_filter_or_cow_bs(bs); include_base || p != base;
>           p = bdrv_filter_or_cow_bs(p))
>      {
> -        ret = bdrv_co_block_status(p, want_zero, offset, bytes, pnum, map,
> -                                   file);
> +        ret = bdrv_co_do_block_status(p, want_zero, offset, bytes, pnum, 
> map, file);

Did you intend to rewrap this line at 80 columns at a different parameter?

With those minor fixes,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org