|
From: | Michael Tokarev |
Subject: | Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file |
Date: | Fri, 2 Jun 2023 00:18:51 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
01.06.2023 22:28, Andrey Drobyshev via пишет:
In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite for loop. Let's detect this case and proceed further down the loop body, as the offsets beyond the old backing size need to be explicitly zeroed. Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
It looks like you forgot the Reviewed-by: Denis V. Lunev here and in the subsequent patch. Should this be backported to -stable? Not that I've seen this issue, it's a quite specific and somewhat rare case.. Thanks, /mjt
[Prev in Thread] | Current Thread | [Next in Thread] |