[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/8] hw/ide/ahci: PxCI should not get cleared when ERR_STA
From: |
Niklas Cassel |
Subject: |
Re: [PATCH v2 5/8] hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set |
Date: |
Wed, 7 Jun 2023 16:32:21 +0000 |
On Wed, Jun 07, 2023 at 06:01:17PM +0200, Niklas Cassel wrote:
> On Mon, Jun 05, 2023 at 08:19:43PM -0400, John Snow wrote:
> > On Thu, Jun 1, 2023 at 9:46 AM Niklas Cassel <nks@flawful.org> wrote:
> > >
> > > From: Niklas Cassel <niklas.cassel@wdc.com>
> > >
> > > For NCQ, PxCI is cleared on command queued successfully.
> > > For non-NCQ, PxCI is cleared on command completed successfully.
> > > Successfully means ERR_STAT, BUSY and DRQ are all cleared.
> > >
> > > A command that has ERR_STAT set, does not get to clear PxCI.
> > > See AHCI 1.3.1, section 5.3.8, states RegFIS:Entry and RegFIS:ClearCI,
> > > and 5.3.16.5 ERR:FatalTaskfile.
> > >
> > > In the case of non-NCQ commands, not clearing PxCI is needed in order
> > > for host software to be able to see which command slot that failed.
> > >
> > > Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> >
> > This patch causes the ahci test suite to hang. You might just need to
> > update the AHCI test suite.
> >
> > "make check" will hang on the ahci-test as of this patch.
>
> Argh :)
>
> Is there any simple way to run only the ahci test suite?
To answer my own question:
QTEST_QEMU_BINARY=./build/qemu-system-x86_64 QTEST_QEMU_IMG=./build/qemu-img
gtester -k --verbose -m=quick build/tests/qtest/ahci-test -o test_log.xml
Kind regards,
Niklas
- [PATCH v2 0/8] misc AHCI cleanups, Niklas Cassel, 2023/06/01
- [PATCH v2 6/8] hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared, Niklas Cassel, 2023/06/01
- [PATCH v2 4/8] hw/ide/ahci: simplify and document PxCI handling, Niklas Cassel, 2023/06/01
- [PATCH v2 7/8] hw/ide/ahci: fix ahci_write_fis_sdb(), Niklas Cassel, 2023/06/01
- [PATCH v2 8/8] hw/ide/ahci: fix broken SError handling, Niklas Cassel, 2023/06/01
- Re: [PATCH v2 0/8] misc AHCI cleanups, John Snow, 2023/06/01