[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/17] util/cacheflush: Avoid possible redundant dcache flush on D
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 04/17] util/cacheflush: Avoid possible redundant dcache flush on Darwin |
Date: |
Tue, 13 Jun 2023 11:38:09 +0200 |
<libkern/OSCacheControl.h> describes sys_icache_invalidate() as
"equivalent to sys_cache_control(kCacheFunctionPrepareForExecution)",
having kCacheFunctionPrepareForExecution defined as:
/* Prepare memory for execution. This should be called
* after writing machine instructions to memory, before
* executing them. It syncs the dcache and icache. [...]
*/
Since the dcache is also sync'd, we can avoid the sys_dcache_flush()
call when both rx/rw pointers are equal.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20230605195911.96033-1-philmd@linaro.org>
---
util/cacheflush.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/util/cacheflush.c b/util/cacheflush.c
index de35616718..a08906155a 100644
--- a/util/cacheflush.c
+++ b/util/cacheflush.c
@@ -241,7 +241,14 @@ static void __attribute__((constructor))
init_cache_info(void)
void flush_idcache_range(uintptr_t rx, uintptr_t rw, size_t len)
{
- sys_dcache_flush((void *)rw, len);
+ if (rx == rw) {
+ /*
+ * sys_icache_invalidate() syncs the dcache and icache,
+ * so no need to call sys_dcache_flush().
+ */
+ } else {
+ sys_dcache_flush((void *)rw, len);
+ }
sys_icache_invalidate((void *)rx, len);
}
#else
--
2.38.1
- [PULL 00/17] Misc patches for 2023-06-13, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 01/17] linux-user, bsd-user: Preserve incoming order of environment variables in the target, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 02/17] cocoa: Fix warnings about invalid prototype declarations, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 03/17] util/cacheflush: Use declarations from <OSCacheControl.h> on Darwin, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 04/17] util/cacheflush: Avoid possible redundant dcache flush on Darwin,
Philippe Mathieu-Daudé <=
- [PULL 05/17] accel/hvf: Report HV_DENIED error, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 06/17] target/hppa/meson: Only build int_helper.o with system emulation, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 07/17] target/i386/helper: Remove do_cpu_sipi() stub for user-mode emulation, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 08/17] target/i386/helper: Shuffle do_cpu_init(), Philippe Mathieu-Daudé, 2023/06/13
- [PULL 09/17] target/i386: Rename helper template headers as '.h.inc', Philippe Mathieu-Daudé, 2023/06/13
- [PULL 10/17] hw/i2c: Enable an id for the pca954x devices, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 11/17] hw/ide/ahci: Remove stray backslash, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 15/17] exec/ram_addr: Return number of dirty pages in cpu_physical_memory_set_dirty_lebitmap(), Philippe Mathieu-Daudé, 2023/06/13
- [PULL 17/17] exec/memory: Introduce RAM_NAMED_FILE flag, Philippe Mathieu-Daudé, 2023/06/13
- [PULL 14/17] hw/char/parallel-isa: Export struct ISAParallelState, Philippe Mathieu-Daudé, 2023/06/13