[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/30] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_d
From: |
Juan Quintela |
Subject: |
[PULL 03/30] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" |
Date: |
Thu, 22 Jun 2023 04:12:53 +0200 |
From: Hyman Huang(黄勇) <yong.huang@smartx.com>
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Note that this patch also delete the unsolicited help message and
clean up the code.
Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-1@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
softmmu/dirtylimit.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/softmmu/dirtylimit.c b/softmmu/dirtylimit.c
index 015a9038d1..5c12d26d49 100644
--- a/softmmu/dirtylimit.c
+++ b/softmmu/dirtylimit.c
@@ -515,14 +515,15 @@ void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict
*qdict)
int64_t cpu_index = qdict_get_try_int(qdict, "cpu_index", -1);
Error *err = NULL;
+ if (dirty_rate < 0) {
+ error_setg(&err, "invalid dirty page limit %ld", dirty_rate);
+ goto out;
+ }
+
qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err);
- if (err) {
- hmp_handle_error(mon, err);
- return;
- }
- monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query "
- "dirty limit for virtual CPU]\n");
+out:
+ hmp_handle_error(mon, err);
}
static struct DirtyLimitInfo *dirtylimit_query_vcpu(int cpu_index)
--
2.40.1
- [PULL 00/30] Next patches, Juan Quintela, 2023/06/21
- [PULL 01/30] migration/multifd: Rename threadinfo.c functions, Juan Quintela, 2023/06/21
- [PULL 03/30] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit",
Juan Quintela <=
- [PULL 02/30] migration/multifd: Protect accesses to migration_threads, Juan Quintela, 2023/06/21
- [PULL 04/30] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter, Juan Quintela, 2023/06/21
- [PULL 05/30] qapi/migration: Introduce vcpu-dirty-limit parameters, Juan Quintela, 2023/06/21
- [PULL 06/30] migration: Introduce dirty-limit capability, Juan Quintela, 2023/06/21
- [PULL 07/30] migration: Refactor auto-converge capability logic, Juan Quintela, 2023/06/21
- [PULL 08/30] migration: Put the detection logic before auto-converge checking, Juan Quintela, 2023/06/21
- [PULL 09/30] migration: Implement dirty-limit convergence algo, Juan Quintela, 2023/06/21
- [PULL 12/30] migration-test: Make machine_opts regular with other options, Juan Quintela, 2023/06/21
- [PULL 11/30] migration-test: Be consistent for ppc, Juan Quintela, 2023/06/21
- [PULL 13/30] migration-test: Create arch_opts, Juan Quintela, 2023/06/21