Re: [PULL 00/30] Next patches

[Richard Henderson]

On 6/22/23 04:12, Juan Quintela wrote:
> The following changes since commit 67fe6ae41da64368bc4936b196fee2bf61f8c720:
>
>    Merge tag 'pull-tricore-20230621-1' ofhttps://github.com/bkoppelmann/qemu  
> into staging (2023-06-21 20:08:48 +0200)
>
> are available in the Git repository at:
>
>    https://gitlab.com/juan.quintela/qemu.git  tags/next-pull-request
>
> for you to fetch changes up to c53dc569d0a0fb76eaa83f353253a897914948f9:
>
>    migration/rdma: Split qemu_fopen_rdma() into input/output functions 
> (2023-06-22 02:45:30 +0200)
>
> ----------------------------------------------------------------
> Migration Pull request (20230621)
>
> In this pull request:
>
> - fix for multifd thread creation (fabiano)
> - dirtylimity (hyman)
>    * migration-test will go on next PULL request, as it has failures.
> - Improve error description (tejus)
> - improve -incoming and set parameters before calling incoming (wei)
> - migration atomic counters reviewed patches (quintela)
> - migration-test refacttoring reviewed (quintela)
>
> Please apply.

You really need to test at least one 32-bit host regularly.
It should be trivial for you to do an i686 build somewhere.

https://gitlab.com/qemu-project/qemu/-/jobs/4518975360#L4817
https://gitlab.com/qemu-project/qemu/-/jobs/4518975263#L3486
https://gitlab.com/qemu-project/qemu/-/jobs/4518975261#L3145
https://gitlab.com/qemu-project/qemu/-/jobs/4518975298#L3372
https://gitlab.com/qemu-project/qemu/-/jobs/4518975301#L3221

../softmmu/dirtylimit.c:558:58: error: format specifies type 'long' but the argument has 
type 'int64_t' (aka 'long long') [-Werror,-Wformat]
        error_setg(&err, "invalid dirty page limit %ld", dirty_rate);
                                                   ~~~   ^~~~~~~~~~
                                                   %lld


r~