[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 2/6] migration: migrate 'inc' command option is deprecated.
From: |
Juan Quintela |
Subject: |
Re: [RFC 2/6] migration: migrate 'inc' command option is deprecated. |
Date: |
Thu, 22 Jun 2023 20:11:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Mon, Jun 12, 2023 at 09:33:40PM +0200, Juan Quintela wrote:
>> Use 'migrate_set_parameter block_incremental true' instead.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> docs/about/deprecated.rst | 7 +++++++
>> qapi/migration.json | 11 +++++++++--
>> migration/migration.c | 5 +++++
>> 3 files changed, 21 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index e1aa0eafc8..c75a3a8f5a 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -433,3 +433,10 @@ Migration
>> ``skipped`` field in Migration stats has been deprecated. It hasn't
>> been used for more than 10 years.
>>
>> +``inc`` migrate command option (since 8.1)
>> +''''''''''''''''''''''''''''''''''''''''''
>> +
>> +The new way to modify migration is using migration parameters.
>> +``inc`` functionality can be acchieved using
>> +``migrate_set_parameter block-incremental true``.
>
> This is a HMP command, but the change affects QMP too. I'd suggest
>
> ``inc`` functionality can be achieved by setting the
> ``block-incremental`` migration parameter to ``true``.
Applied all suggestions. Thanks.
- [RFC 0/6] Migration deprecated parts, Juan Quintela, 2023/06/12
- [RFC 1/6] migration: skipped field is really obsolete., Juan Quintela, 2023/06/12
- [RFC 2/6] migration: migrate 'inc' command option is deprecated., Juan Quintela, 2023/06/12
- [RFC 3/6] migration: migrate 'blk' command option is deprecated., Juan Quintela, 2023/06/12
- [RFC 5/6] migration: Deprecate block migration, Juan Quintela, 2023/06/12
- [RFC 4/6] migration: Deprecate -incoming <uri>, Juan Quintela, 2023/06/12