[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers
From: |
Klaus Jensen |
Subject: |
[PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers |
Date: |
Wed, 28 Jun 2023 11:24:59 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Verify that a reclaim unit handle identifier is only specified once in
fdp.ruhs.
Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index 050fdaf50fcd..c4ea2033bb1c 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -453,6 +453,17 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error
**errp)
free(r);
+ /* verify that the ruhids are unique */
+ for (unsigned int i = 0; i < ns->fdp.nphs; i++) {
+ for (unsigned int j = i + 1; j < ns->fdp.nphs; j++) {
+ if (ruhids[i] == ruhids[j]) {
+ error_setg(errp, "duplicate reclaim unit handle identifier:
%u",
+ ruhids[i]);
+ return false;
+ }
+ }
+ }
+
ph = ns->fdp.phs = g_new(uint16_t, ns->fdp.nphs);
ruhid = ruhids;
--
2.41.0
- [PULL 0/7] hw/nvme updates, Klaus Jensen, 2023/06/28
- [PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err, Klaus Jensen, 2023/06/28
- [PULL 1/7] hw/nvme: add comment for nvme-ns properties, Klaus Jensen, 2023/06/28
- [PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY, Klaus Jensen, 2023/06/28
- [PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers,
Klaus Jensen <=
- [PULL 4/7] hw/nvme: fix verification of number of ruhis, Klaus Jensen, 2023/06/28
- [PULL 6/7] hw/nvme: add placement handle list ranges, Klaus Jensen, 2023/06/28
- [PULL 7/7] docs: update hw/nvme documentation for TP4146, Klaus Jensen, 2023/06/28
- Re: [PULL 0/7] hw/nvme updates, Richard Henderson, 2023/06/28