[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/8] python: silence pylint raising-non-exception error
From: |
Kevin Wolf |
Subject: |
[PULL 6/8] python: silence pylint raising-non-exception error |
Date: |
Thu, 14 Nov 2024 17:56:55 +0100 |
From: John Snow <jsnow@redhat.com>
As of (at least) pylint 3.3.1, this code trips pylint up into believing
we are raising something other than an Exception. We are not: the first
two values may indeed be "None", but the last and final value must by
definition be a SystemExit exception.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-ID: <20241101173700.965776-5-jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
python/scripts/mkvenv.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/python/scripts/mkvenv.py b/python/scripts/mkvenv.py
index f2526af0a0..8ac5b0b2a0 100644
--- a/python/scripts/mkvenv.py
+++ b/python/scripts/mkvenv.py
@@ -379,6 +379,9 @@ def make_venv( # pylint: disable=too-many-arguments
try:
builder.create(str(env_dir))
except SystemExit as exc:
+ # pylint 3.3 bug:
+ # pylint: disable=raising-non-exception, raise-missing-from
+
# Some versions of the venv module raise SystemExit; *nasty*!
# We want the exception that prompted it. It might be a subprocess
# error that has output we *really* want to see.
--
2.47.0
- [PULL 0/8] Block layer patches, Kevin Wolf, 2024/11/14
- [PULL 1/8] migration: Check current_migration in migration_is_running(), Kevin Wolf, 2024/11/14
- [PULL 2/8] parallels: fix possible int overflow, Kevin Wolf, 2024/11/14
- [PULL 3/8] iotests: reflow ReproducibleTestRunner arguments, Kevin Wolf, 2024/11/14
- [PULL 6/8] python: silence pylint raising-non-exception error,
Kevin Wolf <=
- [PULL 4/8] iotests: correct resultclass type in ReproducibleTestRunner, Kevin Wolf, 2024/11/14
- [PULL 8/8] vl: use qmp_device_add() in qemu_create_cli_devices(), Kevin Wolf, 2024/11/14
- [PULL 5/8] python: disable too-many-positional-arguments warning, Kevin Wolf, 2024/11/14
- [PULL 7/8] qdev-monitor: avoid QemuOpts in QMP device_add, Kevin Wolf, 2024/11/14
- Re: [PULL 0/8] Block layer patches, Peter Maydell, 2024/11/15