qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b9ec52: target/xtensa: fix break_dependency f


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b9ec52: target/xtensa: fix break_dependency for repeated r...
Date: Thu, 28 Mar 2019 02:14:18 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b9ec52188f1eafb2901d37a57727bbf1d8bbe3ca
      
https://github.com/qemu/qemu/commit/b9ec52188f1eafb2901d37a57727bbf1d8bbe3ca
  Author: Max Filippov <address@hidden>
  Date:   2019-03-21 (Thu, 21 Mar 2019)

  Changed paths:
    M target/xtensa/translate.c
    M tests/tcg/xtensa/test_flix.S

  Log Message:
  -----------
  target/xtensa: fix break_dependency for repeated resources

break_dependency incorrectly handles the case of dependency on an opcode
that references the same register multiple times. E.g. the following
instruction is translated incorrectly:

  { or a2, a3, a3 ; or a3, a2, a2 }

This happens because resource indices of both dependency graph nodes are
incremented, and a copy for the second instance of the same register in
the ending node is not done.
Only increment resource index of the ending node of the dependency.
Add test.

Signed-off-by: Max Filippov <address@hidden>


  Commit: 393cf60bf75541e1090b1573ce88d6d2b9209c2a
      
https://github.com/qemu/qemu/commit/393cf60bf75541e1090b1573ce88d6d2b9209c2a
  Author: Max Filippov <address@hidden>
  Date:   2019-03-23 (Sat, 23 Mar 2019)

  Changed paths:
    M target/xtensa/xtensa-semi.c

  Log Message:
  -----------
  target/xtensa: don't announce exit simcall

Don't announce that exit simcall has been invoked: this is just noise.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Max Filippov <address@hidden>


  Commit: bc19449acc2e05854118a47cdf96c1e86b30740d
      
https://github.com/qemu/qemu/commit/bc19449acc2e05854118a47cdf96c1e86b30740d
  Author: Max Filippov <address@hidden>
  Date:   2019-03-23 (Sat, 23 Mar 2019)

  Changed paths:
    M tests/tcg/xtensa/Makefile.softmmu-target
    R tests/tcg/xtensa/test_fail.S
    R tests/tcg/xtensa/test_pipeline.S

  Log Message:
  -----------
  tests/tcg/xtensa: clean up test set

Drop test_fail: we know that exit simcall works. Now that it's not run
automatically there's no point in keeping it.
Drop test_pipeline: we're not modeling pipeline, we don't control ccount
and there's no plan to do so.
Enable test_boolean: it won't break on cores without boolean option, it
will do testing on cores with boolean option.

Signed-off-by: Max Filippov <address@hidden>


  Commit: 2fc8d6f8e4d959b05e9225b46dad414bd8f54f88
      
https://github.com/qemu/qemu/commit/2fc8d6f8e4d959b05e9225b46dad414bd8f54f88
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-28 (Thu, 28 Mar 2019)

  Changed paths:
    M target/xtensa/translate.c
    M target/xtensa/xtensa-semi.c
    M tests/tcg/xtensa/Makefile.softmmu-target
    R tests/tcg/xtensa/test_fail.S
    M tests/tcg/xtensa/test_flix.S
    R tests/tcg/xtensa/test_pipeline.S

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/xtensa/tags/20190326-xtensa' into 
staging

target/xtensa fixes for v4.0:

- fix translation of FLIX bundles with multiple references to the same
  register;
- don't announce exit simcall;
- clean up tests/tcg/xtensa.

# gpg: Signature made Tue 26 Mar 2019 17:58:59 GMT
# gpg:                using RSA key 2B67854B98E5327DCDEB17D851F9CC91F83FA044
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Max Filippov <address@hidden>" [unknown]
# gpg:                 aka "Max Filippov <address@hidden>" [full]
# gpg:                 aka "Max Filippov <address@hidden>" [full]
# Primary key fingerprint: 2B67 854B 98E5 327D CDEB  17D8 51F9 CC91 F83F A044

* remotes/xtensa/tags/20190326-xtensa:
  tests/tcg/xtensa: clean up test set
  target/xtensa: don't announce exit simcall
  target/xtensa: fix break_dependency for repeated resources

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/49fc899f8d67...2fc8d6f8e4d9



reply via email to

[Prev in Thread] Current Thread [Next in Thread]