[Qemu-commits] [qemu/qemu] a5bf9f: numa: improve cpu hotplug error message with a wro...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a5bf9fbcc92322e9919113c14dee9838bee4cab4
      
https://github.com/qemu/qemu/commit/a5bf9fbcc92322e9919113c14dee9838bee4cab4
  Author: Laurent Vivier <address@hidden>
  Date:   2019-06-07 (Fri, 07 Jun 2019)

  Changed paths:
    M numa.c

  Log Message:
  -----------
  numa: improve cpu hotplug error message with a wrong node-id

On pseries, core-ids are strongly binded to a node-id by the command
line option. If an user tries to add a CPU to the wrong node, he has
an error but it is not really helpful:

  qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
                        -numa node,nodeid=0 -numa node,nodeid=1 ...

  (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
  Error: node-id=1 must match numa node specified with -numa option

This patch improves this error message by giving to the user the good
node-id to use with the core-id he's providing

  Error: invalid node-id, must be 0

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 754f1dbcf1d4d543167e3212366055761c30bcf4
      
https://github.com/qemu/qemu/commit/754f1dbcf1d4d543167e3212366055761c30bcf4
  Author: Wainer dos Santos Moschetta <address@hidden>
  Date:   2019-06-07 (Fri, 07 Jun 2019)

  Changed paths:
    M include/sysemu/accel.h

  Log Message:
  -----------
  accel: Remove unused AccelClass::opt_name attribute

The AccelType type was converted to AccelClass QOM
object on b14a0b7469f, and the original data type had
a field to store the option name which in turn was
used to search an accelerator. The lookup method
(accel_find) changed too, making the option field
unnecessary but it became AccelClass::opt_name despite
that. Therefore, and given that none accelerator
implementation sets AccelClass::opt_name, let's
remove this attribute.

Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 69600052120bfe651a10b8ae07f20163d895e5da
      
https://github.com/qemu/qemu/commit/69600052120bfe651a10b8ae07f20163d895e5da
  Author: Peter Maydell <address@hidden>
  Date:   2019-06-10 (Mon, 10 Jun 2019)

  Changed paths:
    M include/sysemu/accel.h
    M numa.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/ehabkost/tags/machine-next-pull-request' into staging

Machine Core queue, 2019-06-07

* Improve CPU hotplug error message
  (Laurent Vivier)
* Remove unused AccelClass::opt_name field
  (Wainer dos Santos Moschetta)

# gpg: Signature made Fri 07 Jun 2019 19:31:28 BST
# gpg:                using RSA key 2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>" [full]
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-next-pull-request:
  accel: Remove unused AccelClass::opt_name attribute
  numa: improve cpu hotplug error message with a wrong node-id

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/185b7ccc1135...69600052120b