[Qemu-commits] [qemu/qemu] c799d2: ati-vga: Improve readability of ati_2d_blt function

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c799d2ee7e92433128ed9256a5fcc35f40f2f6c2
      
https://github.com/qemu/qemu/commit/c799d2ee7e92433128ed9256a5fcc35f40f2f6c2
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M hw/display/ati_2d.c

  Log Message:
  -----------
  ati-vga: Improve readability of ati_2d_blt function

Move common parts before the switch to remove code duplication and
improve readibility.

Signed-off-by: BALATON Zoltan <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a38127414bd007c5b6ae64c664d9e8839393277e
      
https://github.com/qemu/qemu/commit/a38127414bd007c5b6ae64c664d9e8839393277e
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M hw/display/ati.c
    M hw/display/ati_2d.c

  Log Message:
  -----------
  ati-vga: Fix frame buffer endianness for big endian target

The extended mode frame buffer should be little endian even when
emulating big endian machine (such as PPC). This fixes color problems
with MorphOS.

Signed-off-by: BALATON Zoltan <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 584acf34cb05f16e13a46d666196a7583d232616
      
https://github.com/qemu/qemu/commit/584acf34cb05f16e13a46d666196a7583d232616
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M hw/display/ati_2d.c

  Log Message:
  -----------
  ati-vga: Fix reverse bit blts

The pixman library only supports blts with left to right, top to
bottom order but the ATI VGA engine can also do different directions.
Fix support for these via a temporary buffer for now. This fixes
rendering issues related to such blts (such as moving windows) but
some other glitches still remain.

Signed-off-by: BALATON Zoltan <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 146dd326c1ff5869ba9e243e30325c44d696c996
      
https://github.com/qemu/qemu/commit/146dd326c1ff5869ba9e243e30325c44d696c996
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M hw/display/ati.c

  Log Message:
  -----------
  ati-vga: Fix setting offset together with pitch for r128pro

Turns out my last fix to this broke one case for Rage 128 Pro so
revert that part of previous patch. This now fixes the remaining
rendering problems for MorphOS which now can produce picture with
-device ati-vga (although it may not be optimised yet and video
overlay emulation is still known to be missing).

Fixes: 866ad5f5ff620078f88183aa254f7b02727e6aa3
Signed-off-by: BALATON Zoltan <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: dba519a2980ab4ba2b3f89546f382de7199eabb6
      
https://github.com/qemu/qemu/commit/dba519a2980ab4ba2b3f89546f382de7199eabb6
  Author: Peter Maydell <address@hidden>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M hw/display/ati.c
    M hw/display/ati_2d.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20190705-pull-request' 
into staging

vga: more ati bugfixes.

# gpg: Signature made Fri 05 Jul 2019 14:42:30 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20190705-pull-request:
  ati-vga: Fix setting offset together with pitch for r128pro
  ati-vga: Fix reverse bit blts
  ati-vga: Fix frame buffer endianness for big endian target
  ati-vga: Improve readability of ati_2d_blt function

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/0050f9978e47...dba519a2980a