[Qemu-commits] [qemu/qemu] f5cf94: vfio-ccw: Test vfio_set_irq_signaling() return value

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f5cf94cdabd349eedc6d0fa69ba51ff4d84c2181
      
https://github.com/qemu/qemu/commit/f5cf94cdabd349eedc6d0fa69ba51ff4d84c2181
  Author: Alex Williamson <address@hidden>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M hw/vfio/ccw.c

  Log Message:
  -----------
  vfio-ccw: Test vfio_set_irq_signaling() return value

Coverity doesn't like that most callers of vfio_set_irq_signaling() check
the return value and doesn't understand the equivalence of testing the
error pointer instead.  Test the return value consistently.

Reported-by: Coverity (CID 1402783)
Signed-off-by: Alex Williamson <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 9ef2d19e5f5dfdebc9877c77951c28f25c74e000
      
https://github.com/qemu/qemu/commit/9ef2d19e5f5dfdebc9877c77951c28f25c74e000
  Author: Pierre Morel <address@hidden>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M target/s390x/cpu_features_def.inc.h
    M target/s390x/cpu_models.c
    M target/s390x/gen-features.c

  Log Message:
  -----------
  s390x/cpumodel: Set up CPU model for AQIC interception

Let's add support for the AP-Queue interruption facility to the CPU
model.

The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CPU facility indicates
whether the PQAP instruction with the AQIC command is available
to the guest.
This feature will be enabled only if the AP instructions are
available on the linux host and AQIC facility is installed on
the host.

This feature must be turned on from userspace to intercept AP
instructions on the KVM guest. The QEMU command line to turn
this feature on looks something like this:

    qemu-system-s390x ... -cpu xxx,apqi=on ...
or
    ... -cpu host

Right now AP pass-through devices do not support migration,
which means that we do not have to take care of migrating
the interrupt data:
virsh migrate apguest --live qemu+ssh://address@hidden/system
error: Requested operation is not valid: domain has assigned non-USB host 
devices

Signed-off-by: Pierre Morel <address@hidden>
Reviewed-by: Tony Krowiak <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
[rebase to newest qemu and fixup description]
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: d05be57ddc2e1722f527aa4c20d84dfd15c840ec
      
https://github.com/qemu/qemu/commit/d05be57ddc2e1722f527aa4c20d84dfd15c840ec
  Author: Christian Borntraeger <address@hidden>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M target/s390x/cpu_features_def.inc.h

  Log Message:
  -----------
  s390: cpumodel: fix description for the new vector facility

The new facility is called "Vector-Packed-Decimal-Enhancement Facility"
and not "Vector BCD enhancements facility 1". As the shortname might
have already found its way into some backports, let's keep vxbeh.

Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
Signed-off-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 92b9afe45e10edd8eaed6329366201c2165a8065
      
https://github.com/qemu/qemu/commit/92b9afe45e10edd8eaed6329366201c2165a8065
  Author: Cornelia Huck <address@hidden>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M target/s390x/translate_vx.inc.c

  Log Message:
  -----------
  s390x/tcg: move fallthrough annotation

...so that the compiler properly recognizes it.

Reported-by: Stefan Weil <address@hidden>
Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND 
ZERO")
Message-Id: <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: f89600f498933655c9d11c72e2e6f210e7d8dcb4
      
https://github.com/qemu/qemu/commit/f89600f498933655c9d11c72e2e6f210e7d8dcb4
  Author: Peter Maydell <address@hidden>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M hw/vfio/ccw.c
    M target/s390x/cpu_features_def.inc.h
    M target/s390x/cpu_models.c
    M target/s390x/gen-features.c
    M target/s390x/translate_vx.inc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190709' into staging

Fixes in cpu models, tcg, and vfio-ccw.

# gpg: Signature made Tue 09 Jul 2019 13:20:52 BST
# gpg:                using RSA key C3D0D66DC3624FF6A8C018CEDECF6B93C6F02FAF
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Cornelia Huck <address@hidden>" [unknown]
# gpg:                 aka "Cornelia Huck <address@hidden>" [full]
# gpg:                 aka "Cornelia Huck <address@hidden>" [full]
# gpg:                 aka "Cornelia Huck <address@hidden>" [unknown]
# gpg:                 aka "Cornelia Huck <address@hidden>" [unknown]
# Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0  18CE DECF 6B93 C6F0 2FAF

* remotes/cohuck/tags/s390x-20190709:
  s390x/tcg: move fallthrough annotation
  s390: cpumodel: fix description for the new vector facility
  s390x/cpumodel: Set up CPU model for AQIC interception
  vfio-ccw: Test vfio_set_irq_signaling() return value

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a538626aff7c...f89600f49893