[Qemu-commits] [qemu/qemu] 45222b: fuzz: fix broken qtest check at rcu_disable_atfork

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 45222b9a9016488289a1938a528239c3b83eddb1
      
https://github.com/qemu/qemu/commit/45222b9a9016488289a1938a528239c3b83eddb1
  Author: Alexander Bulekov <alxndr@bu.edu>
  Date:   2020-07-06 (Mon, 06 Jul 2020)

  Changed paths:
    M softmmu/vl.c
    M tests/qtest/fuzz/fuzz.c

  Log Message:
  -----------
  fuzz: fix broken qtest check at rcu_disable_atfork

The qtest_enabled check introduced in d6919e4 always returns false, as
it is called prior to configure_accelerators(). Instead of trying to
skip rcu_disable_atfork in qemu_main, simply call rcu_enable_atfork in
the fuzzer, after qemu_main returns.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200618160516.2817-1-alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: dda2f556c3503758680b6a868fc49c4886a5039f
      
https://github.com/qemu/qemu/commit/dda2f556c3503758680b6a868fc49c4886a5039f
  Author: Alexander Bulekov <alxndr@bu.edu>
  Date:   2020-07-06 (Mon, 06 Jul 2020)

  Changed paths:
    M tests/qtest/fuzz/fork_fuzz.c

  Log Message:
  -----------
  fuzz: do not use POSIX shm for coverage bitmap

We used shm_open with mmap to share libfuzzer's coverage bitmap with
child (runner) processes. The same functionality can be achieved with
MAP_SHARED | MAP_ANONYMOUS, since we do not care about naming or
permissioning the shared memory object.

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200622165040.15121-1-alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 51b3ca97592964a0ece22f9df92592e0f80a78fe
      
https://github.com/qemu/qemu/commit/51b3ca97592964a0ece22f9df92592e0f80a78fe
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-07-06 (Mon, 06 Jul 2020)

  Changed paths:
    M tests/qtest/device-introspect-test.c
    M tests/qtest/libqtest.c
    M tests/qtest/qom-test.c
    M tests/qtest/test-hmp.c

  Log Message:
  -----------
  tests/qtest: Unify the test for the xenfv and xenpv machines

We have the same check in three places. Let's unify it in a central
place instead.

Message-Id: <20200622104339.21000-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 9df8b20d1632d108da316134d4d86a00b4028803
      
https://github.com/qemu/qemu/commit/9df8b20d1632d108da316134d4d86a00b4028803
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-07-06 (Mon, 06 Jul 2020)

  Changed paths:
    M configure
    M util/qemu-openpty.c

  Log Message:
  -----------
  configure / util: Auto-detect the availability of openpty()

Recent versions of Solaris (v11.4) now feature an openpty() function,
too, causing a build failure since we ship our own implementation of
openpty() for Solaris in util/qemu-openpty.c so far. Since there are
now both variants available in the wild, with and without this function
(and illumos is said to not have this function yet), let's introduce a
proper HAVE_OPENPTY define for this to fix the build failure.

Message-Id: <20200702143955.678-1-thuth@redhat.com>
Tested-by: Michele Denber <denber@mindspring.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: c7aab58ba0baaf82422b7f7b0d7ad63b0db8d166
      
https://github.com/qemu/qemu/commit/c7aab58ba0baaf82422b7f7b0d7ad63b0db8d166
  Author: Thomas Huth <huth@tuxfamily.org>
  Date:   2020-07-06 (Mon, 06 Jul 2020)

  Changed paths:
    M hw/m68k/mcf5206.c

  Log Message:
  -----------
  hw/m68k/mcf5206: Replace remaining hw_error()s by qemu_log_mask()

hw_error() dumps the CPU state and exits QEMU. This is ok during initial
code development (to see where the guest code is currently executing),
but it is certainly not the desired behavior that we want to present to
normal users, and it can also cause trouble when e.g. fuzzing devices.
Thus let's replace these hw_error()s by qemu_log_mask()s instead.

Message-Id: <20200611055807.15921-1-huth@tuxfamily.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <huth@tuxfamily.org>


  Commit: 8c4329214f1d4484205e6f7c48e98ff26969eb56
      
https://github.com/qemu/qemu/commit/8c4329214f1d4484205e6f7c48e98ff26969eb56
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-07-06 (Mon, 06 Jul 2020)

  Changed paths:
    M MAINTAINERS
    A tests/acceptance/machine_sparc64_sun4u.py

  Log Message:
  -----------
  tests/acceptance: Add a test for the sun4u sparc64 machine

We can use the image from the advent calendar 2018 to test the sun4u
machine. It's not using the "QEMU advent calendar" string, so we can
not use the do_test_advcal_2018() from boot_linux_console.py, thus
let's also put it into a separate file to also be able to add an
entry to the MAINTAINERS file.

Message-Id: <20200704173519.26087-1-thuth@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 710fb08fd297d7a92163debce1959fae8f3b6ed7
      
https://github.com/qemu/qemu/commit/710fb08fd297d7a92163debce1959fae8f3b6ed7
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M MAINTAINERS
    M configure
    M hw/m68k/mcf5206.c
    M softmmu/vl.c
    A tests/acceptance/machine_sparc64_sun4u.py
    M tests/qtest/device-introspect-test.c
    M tests/qtest/fuzz/fork_fuzz.c
    M tests/qtest/fuzz/fuzz.c
    M tests/qtest/libqtest.c
    M tests/qtest/qom-test.c
    M tests/qtest/test-hmp.c
    M util/qemu-openpty.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2020-07-06' into staging

* Fuzzer fixes from Alexander
* Clean-up patches for qtests, configure and mcf5206
* Sparc64 sun4u acceptance test

# gpg: Signature made Mon 06 Jul 2020 08:34:14 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2020-07-06:
  tests/acceptance: Add a test for the sun4u sparc64 machine
  hw/m68k/mcf5206: Replace remaining hw_error()s by qemu_log_mask()
  configure / util: Auto-detect the availability of openpty()
  tests/qtest: Unify the test for the xenfv and xenpv machines
  fuzz: do not use POSIX shm for coverage bitmap
  fuzz: fix broken qtest check at rcu_disable_atfork

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7623b5ba017f...710fb08fd297