qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bc282d: migration/multifd: Rename threadinfo.


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] bc282d: migration/multifd: Rename threadinfo.c functions
Date: Thu, 22 Jun 2023 10:16:38 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: bc282d31eb9addbe3555925c455b5e4e8b94f000
      
https://github.com/qemu/qemu/commit/bc282d31eb9addbe3555925c455b5e4e8b94f000
  Author: Fabiano Rosas <farosas@suse.de>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c
    M migration/multifd.c
    M migration/threadinfo.c
    M migration/threadinfo.h

  Log Message:
  -----------
  migration/multifd: Rename threadinfo.c functions

We're about to add more functions to this file so make it use the same
coding style as the rest of the code.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20230607161306.31425-2-farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: c5da33c0f6881a4f9e95cd67f22812c85eb958f8
      
https://github.com/qemu/qemu/commit/c5da33c0f6881a4f9e95cd67f22812c85eb958f8
  Author: Fabiano Rosas <farosas@suse.de>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/threadinfo.c
    M migration/threadinfo.h

  Log Message:
  -----------
  migration/multifd: Protect accesses to migration_threads

This doubly linked list is common for all the multifd and migration
threads so we need to avoid concurrent access.

Add a mutex to protect the data from concurrent access. This fixes a
crash when removing two MigrationThread objects from the list at the
same time during cleanup of multifd threads.

Fixes: 671326201d ("migration: Introduce interface query-migrationthreads")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230607161306.31425-3-farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 869e2fca712c1b945a71267856d329edeae93b9e
      
https://github.com/qemu/qemu/commit/869e2fca712c1b945a71267856d329edeae93b9e
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.

Note that this patch also delete the unsolicited help message and
clean up the code.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-1@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 8ea76af72619445e96680b27ff9163d0c99a821a
      
https://github.com/qemu/qemu/commit/8ea76af72619445e96680b27ff9163d0c99a821a
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration-hmp-cmds.c
    M migration/options.c
    M qapi/migration.json

  Log Message:
  -----------
  qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

Introduce "x-vcpu-dirty-limit-period" migration experimental
parameter, which is in the range of 1 to 1000ms and used to
make dirtyrate calculation period configurable.

Currently with the "x-vcpu-dirty-limit-period" varies, the
total time of live migration changes, test results show the
optimal value of "x-vcpu-dirty-limit-period" ranges from
500ms to 1000 ms. "x-vcpu-dirty-limit-period" should be made
stable once it proves best value can not be determined with
developer's experiments.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-2@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 1b747b17b69d1b65889f4e8f826f5f8fbb04af58
      
https://github.com/qemu/qemu/commit/1b747b17b69d1b65889f4e8f826f5f8fbb04af58
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration-hmp-cmds.c
    M migration/options.c
    M qapi/migration.json

  Log Message:
  -----------
  qapi/migration: Introduce vcpu-dirty-limit parameters

Introduce "vcpu-dirty-limit" migration parameter used
to limit dirty page rate during live migration.

"vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
two dirty-limit-related migration parameters, which can
be set before and during live migration by qmp
migrate-set-parameters.

This two parameters are used to help implement the dirty
page rate limit algo of migration.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-3@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 7a1f83b9a66f3de9248075f95c6e3de5cb0c1585
      
https://github.com/qemu/qemu/commit/7a1f83b9a66f3de9248075f95c6e3de5cb0c1585
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/options.c
    M migration/options.h
    M qapi/migration.json
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  migration: Introduce dirty-limit capability

Introduce migration dirty-limit capability, which can
be turned on before live migration and limit dirty
page rate durty live migration.

Introduce migrate_dirty_limit function to help check
if dirty-limit capability enabled during live migration.

Meanwhile, refactor vcpu_dirty_rate_stat_collect
so that period can be configured instead of hardcoded.

dirty-limit capability is kind of like auto-converge
but using dirty limit instead of traditional cpu-throttle
to throttle guest down. To enable this feature, turn on
the dirty-limit capability before live migration using
migrate-set-capabilities, and set the parameters
"x-vcpu-dirty-limit-period", "vcpu-dirty-limit" suitably
to speed up convergence.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-4@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: f8739a03f31f50a5bca44be36fcdb023919b73f0
      
https://github.com/qemu/qemu/commit/f8739a03f31f50a5bca44be36fcdb023919b73f0
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: Refactor auto-converge capability logic

Check if block migration is running before throttling
guest down in auto-converge way.

Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-5@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 1f769c31995c5efb6a1adef2c357a9caf8511baf
      
https://github.com/qemu/qemu/commit/1f769c31995c5efb6a1adef2c357a9caf8511baf
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: Put the detection logic before auto-converge checking

This commit is prepared for the implementation of dirty-limit
convergence algo.

The detection logic of throttling condition can apply to both
auto-converge and dirty-limit algo, putting it's position
before the checking logic for auto-converge feature.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-6@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: f535524fb23fc9c4ba592512d62ed228a865ca97
      
https://github.com/qemu/qemu/commit/f535524fb23fc9c4ba592512d62ed228a865ca97
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c
    M migration/ram.c
    M migration/trace-events
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  migration: Implement dirty-limit convergence algo

Implement dirty-limit convergence algo for live migration,
which is kind of like auto-converge algo but using dirty-limit
instead of cpu throttle to make migration convergent.

Enable dirty page limit if dirty_rate_high_cnt greater than 2
when dirty-limit capability enabled, Disable dirty-limit if
migration be canceled.

Note that "set_vcpu_dirty_limit", "cancel_vcpu_dirty_limit"
commands are not allowed during dirty-limit live migration.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-7@git.sr.ht>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 102a25b5061551f12c39b29ab203e8248647e01c
      
https://github.com/qemu/qemu/commit/102a25b5061551f12c39b29ab203e8248647e01c
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M include/sysemu/dirtylimit.h
    M migration/migration-hmp-cmds.c
    M migration/migration.c
    M qapi/migration.json
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  migration: Extend query-migrate to provide dirty page limit info

Extend query-migrate to provide throttle time and estimated
ring full time with dirty-limit capability enabled, through which
we can observe if dirty limit take effect during live migration.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-8@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 152ea418eda321453c35c0bac69ee2bfa61851e2
      
https://github.com/qemu/qemu/commit/152ea418eda321453c35c0bac69ee2bfa61851e2
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Be consistent for ppc

It makes no sense that we don't have the same configuration on both sides.

Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Message-ID: <20230608224943.3877-2-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: bb45df4177767534aa9f400ed79a38f2adcf1bba
      
https://github.com/qemu/qemu/commit/bb45df4177767534aa9f400ed79a38f2adcf1bba
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Make machine_opts regular with other options

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230608224943.3877-5-quintela@redhat.com>


  Commit: 6b40ad5c1f09b398c0de099c88c816a033ecbb44
      
https://github.com/qemu/qemu/commit/6b40ad5c1f09b398c0de099c88c816a033ecbb44
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Create arch_opts

This will contain the options needed for both source and target.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-6-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 06973f0249be85ac313a18015a00f5b677703a53
      
https://github.com/qemu/qemu/commit/06973f0249be85ac313a18015a00f5b677703a53
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: machine_opts is really arch specific

And it needs to be in both source and target, so put it on arch_opts.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-7-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 7455ee794c01662b5efa1ee67396d85943663ded
      
https://github.com/qemu/qemu/commit/7455ee794c01662b5efa1ee67396d85943663ded
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Create kvm_opts

So arch_dirty_ring option becomes one option like the others.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-8-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 2f0fb05d052068628e0c05a0fbafdb544de30d10
      
https://github.com/qemu/qemu/commit/2f0fb05d052068628e0c05a0fbafdb544de30d10
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: bootpath is the same for all tests and for all archs

So just make it a global variable.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-9-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: f34e635720209ce2292f0928189f86654df54e0e
      
https://github.com/qemu/qemu/commit/f34e635720209ce2292f0928189f86654df54e0e
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Add bootfile_create/delete() functions

The bootsector code is read only from the guest (otherwise we are
going to have problems with it being read from both source and
destination).

Create a single copy for all the tests.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-10-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 2df3c8a2faa86ab4d99299b9670b0040c2846905
      
https://github.com/qemu/qemu/commit/2df3c8a2faa86ab4d99299b9670b0040c2846905
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: dirtylimit checks for x86_64 arch before

So no need to assert we are in x86_64.
Once there, refactor the function to remove useless variables.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-11-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 13a7be0a07e015d1ffc76fca1de1615aad27c1d6
      
https://github.com/qemu/qemu/commit/13a7be0a07e015d1ffc76fca1de1615aad27c1d6
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: simplify shmem_opts handling

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-4-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 7ca7ce26bd5958d3bd80b23386c76e49c8141e4d
      
https://github.com/qemu/qemu/commit/7ca7ce26bd5958d3bd80b23386c76e49c8141e4d
  Author: Tejus GK <tejus.gk@nutanix.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Update error description whenever migration fails

There are places in migration.c where the migration is marked failed with
MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
libvirt doesn't know why the migration failed when it queries for it.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Tejus GK <tejus.gk@nutanix.com>
Message-ID: <20230621130940.178659-2-tejus.gk@nutanix.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: ddd77bcaabae3faec0c53462a7518225cc85cb43
      
https://github.com/qemu/qemu/commit/ddd77bcaabae3faec0c53462a7518225cc85cb43
  Author: Tejus GK <tejus.gk@nutanix.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Refactor repeated call of yank_unregister_instance

In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Tejus GK <tejus.gk@nutanix.com>
Message-ID: <20230621130940.178659-3-tejus.gk@nutanix.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 3803d69bae99b954c252b6b9c6ec39511ca61f83
      
https://github.com/qemu/qemu/commit/3803d69bae99b954c252b6b9c6ec39511ca61f83
  Author: Wei Wang <wei.w.wang@intel.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/options.c

  Log Message:
  -----------
  migration: enforce multifd and postcopy preempt to be set before incoming

qemu_start_incoming_migration needs to check the number of multifd
channels or postcopy ram channels to configure the backlog parameter (i.e.
the maximum length to which the queue of pending connections for sockfd
may grow) of listen(). So enforce the usage of postcopy-preempt and
multifd as below:
- need to use "-incoming defer" on the destination; and
- set_capability and set_parameter need to be done before migrate_incoming

Otherwise, disable the use of the features and report error messages to
remind users to adjust the commands.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230606101910.20456-2-wei.w.wang@intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>


  Commit: e3e73d389977e5a8223ba39282ed71e0b607d9e0
      
https://github.com/qemu/qemu/commit/e3e73d389977e5a8223ba39282ed71e0b607d9e0
  Author: Wei Wang <wei.w.wang@intel.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  qtest/migration-tests.c: use "-incoming defer" for postcopy tests

The Postcopy preempt capability is expected to be set before incoming
starts, so change the postcopy tests to start with deferred incoming and
call migrate-incoming after the cap has been set.

Why the existing tests (without this patch) didn't fail?
There could be two reasons:
1) "backlog" specifies the number of pending connections. As long as the
   server accepts the connections faster than the clients side connecting,
   connection will succeed. For the preempt test, it uses only 2 channels,
   so very likely to not have pending connections.
2) per my tests (on kernel 6.2), the number of pending connections allowed
   is actually "backlog + 1", which is 2 in this case.
That said, the implementation of socket_start_incoming_migration_internal
expects "migrate defer" to be used, and for safety, change the test to
work with the expected usage.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230606101910.20456-3-wei.w.wang@intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 74e43969769fc44fb1b49f488d38d7c7ac22c73a
      
https://github.com/qemu/qemu/commit/74e43969769fc44fb1b49f488d38d7c7ac22c73a
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h
    M migration/savevm.c
    M migration/vmstate.c

  Log Message:
  -----------
  qemu-file: Rename qemu_file_transferred_ fast -> noflush

Fast don't say much.  Noflush indicates more clearly that it is like
qemu_file_transferred but without the flush.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230530183941.7223-2-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: d8badc3316b76db48f60ea8d4b1cb448982b5032
      
https://github.com/qemu/qemu/commit/d8badc3316b76db48f60ea8d4b1cb448982b5032
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration: Change qemu_file_transferred to noflush

We do a qemu_fclose() just after that, that also does a qemu_fflush(),
so remove one qemu_fflush().

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230530183941.7223-3-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: aa0fcb49c00a2653ab004e205bd78dbf8d8a5416
      
https://github.com/qemu/qemu/commit/aa0fcb49c00a2653ab004e205bd78dbf8d8a5416
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/block.c

  Log Message:
  -----------
  migration: Use qemu_file_transferred_noflush() for block migration.

We only care about the amount of bytes transferred.  Flushing is done
by the system somewhere else.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230530183941.7223-4-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 41c887652526531a8d28bf46a778364c3a8b5b74
      
https://github.com/qemu/qemu/commit/41c887652526531a8d28bf46a778364c3a8b5b74
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h

  Log Message:
  -----------
  qemu_file: Make qemu_file_is_writable() static

It is not used outside of qemu_file, and it shouldn't.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230530183941.7223-19-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: e0419a111ee491da75a79f3b3e606560a1e33181
      
https://github.com/qemu/qemu/commit/e0419a111ee491da75a79f3b3e606560a1e33181
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c

  Log Message:
  -----------
  qemu-file: Simplify qemu_file_shutdown()

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230530183941.7223-20-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 106ac0a0e7bf66c453515df6c7f7b3e737a1bf05
      
https://github.com/qemu/qemu/commit/106ac0a0e7bf66c453515df6c7f7b3e737a1bf05
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h

  Log Message:
  -----------
  qemu-file: Make qemu_file_get_error_obj() static

It was not used outside of qemu_file.c anyways.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230530183941.7223-21-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 23e4307eadc1497bd0a11ca91041768f15963b68
      
https://github.com/qemu/qemu/commit/23e4307eadc1497bd0a11ca91041768f15963b68
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h
    M migration/rdma.c

  Log Message:
  -----------
  migration/rdma: Split qemu_fopen_rdma() into input/output functions

This is how everything else in QEMUFile is structured.
As a bonus they are three less lines of code.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230530183941.7223-17-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: d198dab7131de7787624f64ad7039022220297eb
      
https://github.com/qemu/qemu/commit/d198dab7131de7787624f64ad7039022220297eb
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M include/sysemu/dirtylimit.h
    M migration/block.c
    M migration/migration-hmp-cmds.c
    M migration/migration.c
    M migration/multifd.c
    M migration/options.c
    M migration/options.h
    M migration/qemu-file.c
    M migration/qemu-file.h
    M migration/ram.c
    M migration/rdma.c
    M migration/savevm.c
    M migration/threadinfo.c
    M migration/threadinfo.h
    M migration/trace-events
    M migration/vmstate.c
    M qapi/migration.json
    M softmmu/dirtylimit.c
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  Merge tag 'next-pull-request' of https://gitlab.com/juan.quintela/qemu into 
staging

Migration Pull request (20230621) take 2

In this pull request the only change is fixing 32 bits complitaion issue.

Please apply.

[take 1]
- fix for multifd thread creation (fabiano)
- dirtylimity (hyman)
  * migration-test will go on next PULL request, as it has failures.
- Improve error description (tejus)
- improve -incoming and set parameters before calling incoming (wei)
- migration atomic counters reviewed patches (quintela)
- migration-test refacttoring reviewed (quintela)

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEGJn/jt6/WMzuA0uC9IfvGFhy1yMFAmSUdGkACgkQ9IfvGFhy
# 1yNj+RAAuIwDjqd3Eqg337EmRSryNg9cGGmfaIXeOHsKBmhjlYJticTs+wOtOJ30
# ii+9CmVl0Z7maJvWE5bgPVAN9A+02s5CkDePQpEaNfNJt383pBo4SSv2mp3MHR2x
# qFlbBKXTYXY91dsvLGVyYjHNPRGYoK+vwsQVNq1SA/iL0Rp18o+6lGm65oLtGEYn
# azKBslneRMqgtN4K4My7yPSX7aijsGNdiykaacA6H3Wb1AZYJmdsV1uhzWQ0McTX
# uqHeweSfbudtvp/tdAO6AL/mQ5gUiukvt1fILDtIWkUfAZHl1tRLElMfrWYzp/OB
# hb0C5nWUDvKJ03jgxP94Fzu/n/Ovya5fRos3Xd+bFGWAEiXEozUw0diROjwo/f+m
# z5KNCxbJOCsdkC4jzHoty25VlZ1lFxM5nINlA8xbuJeduPFYq1vayTQiaBpUwlpi
# k7qZh0DwBRgUD+PwiB3dpUpvSXDNXGvFknD0kyJiafXYvf8msAtzv1J9GHoctP7S
# F34Rq11OuUowrsjZ5KEmLJeTjjVTcMUvrfVz2m9vgPyZsIiq9kYM3HS0mZbvW12E
# ytA75wpO0JHrLUUYJeMHZcs7i+eJRVqSUxSYMcT6Nlpcqyq4mItopmcrRXPE3p4E
# ZIOaT0SOTXCnCr+r66AIoWKDAkDQ8FR0OOGZx03NWVfGwY8+J84=
# =+LMI
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 22 Jun 2023 06:18:49 PM CEST
# gpg:                using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723
# gpg: Good signature from "Juan Quintela <quintela@redhat.com>" [undefined]
# gpg:                 aka "Juan Quintela <quintela@trasno.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* tag 'next-pull-request' of https://gitlab.com/juan.quintela/qemu: (30 commits)
  migration/rdma: Split qemu_fopen_rdma() into input/output functions
  qemu-file: Make qemu_file_get_error_obj() static
  qemu-file: Simplify qemu_file_shutdown()
  qemu_file: Make qemu_file_is_writable() static
  migration: Use qemu_file_transferred_noflush() for block migration.
  migration: Change qemu_file_transferred to noflush
  qemu-file: Rename qemu_file_transferred_ fast -> noflush
  qtest/migration-tests.c: use "-incoming defer" for postcopy tests
  migration: enforce multifd and postcopy preempt to be set before incoming
  migration: Refactor repeated call of yank_unregister_instance
  migration: Update error description whenever migration fails
  migration-test: simplify shmem_opts handling
  migration-test: dirtylimit checks for x86_64 arch before
  migration-test: Add bootfile_create/delete() functions
  migration-test: bootpath is the same for all tests and for all archs
  migration-test: Create kvm_opts
  migration-test: machine_opts is really arch specific
  migration-test: Create arch_opts
  migration-test: Make machine_opts regular with other options
  migration-test: Be consistent for ppc
  ...

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b455ce4c2f30...d198dab7131d



reply via email to

[Prev in Thread] Current Thread [Next in Thread]