[Qemu-commits] [qemu/qemu] 7491e0: hw/nvme: add comment for nvme-ns properties

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 7491e0e4096f426de4a47fa241442c84e63c5a64
      
https://github.com/qemu/qemu/commit/7491e0e4096f426de4a47fa241442c84e63c5a64
  Author: Minwoo Im <minwoo.im@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: add comment for nvme-ns properties

Add more comments of existing properties for nvme-ns device.

Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: cab1da59c2ff3bf08d0a7becf9b51e43a724a85c
      
https://github.com/qemu/qemu/commit/cab1da59c2ff3bf08d0a7becf9b51e43a724a85c
  Author: Minwoo Im <minwoo.im@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: consider COPY command in nvme_aio_err

If we don't have NVME_CMD_COPY consideration in the switch statement in
nvme_aio_err(), it will go to have NVME_INTERNAL_DEV_ERROR and
`req->status` will be ovewritten to it.  During the aio context, it
might set the NVMe status field like NVME_CMD_SIZE_LIMIT, but it's
overwritten in the nvme_aio_err().

Add consideration for the NVME_CMD_COPY not to overwrite the status at
the end of the function.

Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 381ab99d858709eab34b65d123a6356b8b1e87bd
      
https://github.com/qemu/qemu/commit/381ab99d858709eab34b65d123a6356b8b1e87bd
  Author: Minwoo Im <minwoo.im@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: check maximum copy length (MCL) for COPY

MCL(Maximum Copy Length) in the Identify Namespace data structure limits
the number of LBAs to be copied inside of the controller.  We've not
checked it at all, so added the check with returning the proper error
status.

Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 3ae8a54a087d54cfd109ab3d844ff4cba54a28d8
      
https://github.com/qemu/qemu/commit/3ae8a54a087d54cfd109ab3d844ff4cba54a28d8
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M hw/nvme/ns.c
    M hw/nvme/subsys.c

  Log Message:
  -----------
  hw/nvme: fix verification of number of ruhis

Fix a off-by-one error when verifying the number of reclaim unit handle
identifiers specified in fdp.ruhs. To make the fix nicer, move the
verification of the fdp.nruh parameter to an earlier point.

Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 94fa8ca7ee9b6215a5c078f5d424377e5fa61b9c
      
https://github.com/qemu/qemu/commit/94fa8ca7ee9b6215a5c078f5d424377e5fa61b9c
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M hw/nvme/ns.c

  Log Message:
  -----------
  hw/nvme: verify uniqueness of reclaim unit handle identifiers

Verify that a reclaim unit handle identifier is only specified once in
fdp.ruhs.

Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: ce8017736cc82e0250c1bc8e383335822f995510
      
https://github.com/qemu/qemu/commit/ce8017736cc82e0250c1bc8e383335822f995510
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M hw/nvme/ns.c

  Log Message:
  -----------
  hw/nvme: add placement handle list ranges

Allow the placement handles to be specified as ranges, i.e.
`fdp.ruhs=1:3-5` will attempt to assign ruh 1, 3, 4 and 5 to the
namespace.

Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: e409c9057b55e890a6e5f70386a36932a5137bcf
      
https://github.com/qemu/qemu/commit/e409c9057b55e890a6e5f70386a36932a5137bcf
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M docs/system/devices/nvme.rst

  Log Message:
  -----------
  docs: update hw/nvme documentation for TP4146

Update documentation for TP4146 ("Flexible Data Placement") emulation.

Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: aa1048e33c76e1fa7d7e7b61e3417be0205f11d8
      
https://github.com/qemu/qemu/commit/aa1048e33c76e1fa7d7e7b61e3417be0205f11d8
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M docs/system/devices/nvme.rst
    M hw/nvme/ctrl.c
    M hw/nvme/ns.c
    M hw/nvme/subsys.c

  Log Message:
  -----------
  Merge tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu into 
staging

hw/nvme updates

Small set of fixes and some updates for the FDP support.

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmSb/D4ACgkQTeGvMW1P
# DemziAf/eQfjnVr57A+Kglf8J15MCW0GiArbHCJfcl9vf0HPP/iY1c9V4cCZjTLG
# vkkkU6W+TFaYALGOVgAldHWC7OCpOi7GHrlqRJDuw86d2dyLDn/l+GQin/rVoocD
# fzF2gRVQU4x9qzmjRUikVhRzZbrB4F/AH6QQ8EV3wx2wrljyusItEGe53FEuCugx
# pwtKrG990188+UCT1ofr2JYhLq3OmYQi3o2fWgzMp9jP+NeROgKaevWG4UEhFonG
# CdeL9BMlSRAfrdR1gTvZpG2mFsrroeBCCjXcrKSwkAxBqpMJDSLvbGqoGJo6kDWm
# c9x82Zy2/wVuQaDk+atmcTF1+Pddgw==
# =//ks
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 28 Jun 2023 11:24:14 AM CEST
# gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
# gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [unknown]
# gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
#      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9

* tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu:
  docs: update hw/nvme documentation for TP4146
  hw/nvme: add placement handle list ranges
  hw/nvme: verify uniqueness of reclaim unit handle identifiers
  hw/nvme: fix verification of number of ruhis
  hw/nvme: check maximum copy length (MCL) for COPY
  hw/nvme: consider COPY command in nvme_aio_err
  hw/nvme: add comment for nvme-ns properties

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b111569da9f8...aa1048e33c76