[Qemu-commits] [qemu/qemu] 80c803: hw/usb: Use __attribute__((packed)) vs __packed

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 80c80346ebd8a36b778cb634732b427862de7cb1
      
https://github.com/qemu/qemu/commit/80c80346ebd8a36b778cb634732b427862de7cb1
  Author: Roque Arcudia Hernandez <roqueh@google.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M include/hw/usb/dwc2-regs.h

  Log Message:
  -----------
  hw/usb: Use __attribute__((packed)) vs __packed

__packed is non standard and is not present in clang-cl.
__attribute__((packed)) has the same semantics.

Signed-off-by: Erwin Jansen <jansene@google.com>
Signed-off-by: Roque Arcudia Hernandez <roqueh@google.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20241101211720.3354111-1-roqueh@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e1f1ccb8f0a476198ce8adff566db26b7143e975
      
https://github.com/qemu/qemu/commit/e1f1ccb8f0a476198ce8adff566db26b7143e975
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M fpu/softfloat-specialize.c.inc
    M target/s390x/tcg/fpu_helper.c
    M target/s390x/tcg/vec_fpu_helper.c

  Log Message:
  -----------
  target/s390x: Fix the floating-point multiply-and-add NaN rules

Order the helper arguments to match the Principles of Operation.
Implement the "Results: MULTIPLY AND ADD" table in pickNaNMulAdd().

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20241023000147.34035-2-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6dc293540e1ceb82d569224a810f59c9a9e4f822
      
https://github.com/qemu/qemu/commit/6dc293540e1ceb82d569224a810f59c9a9e4f822
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M tests/tcg/s390x/Makefile.target
    A tests/tcg/s390x/float.h
    A tests/tcg/s390x/fma.c
    M tests/tcg/s390x/vfminmax.c

  Log Message:
  -----------
  tests/tcg/s390x: Add the floating-point multiply-and-add test

Add a test to prevent regressions.
Share some useful pieces with the vfminmax test.
Remove the duplicates from the floating point class values.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20241023000147.34035-3-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0271fdc650b212533b8aeaecbedfe8ccf6bbbef3
      
https://github.com/qemu/qemu/commit/0271fdc650b212533b8aeaecbedfe8ccf6bbbef3
  Author: Jared Rossi <jrossi@linux.ibm.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M docs/system/s390x/bootdevices.rst

  Log Message:
  -----------
  docs/system/s390x/bootdevices: Update loadparm documentation

Update documentation to include per-device loadparm support.

Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20241115002742.3576842-1-jrossi@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b8c5fdc6588f82d95807be0eb2215d215a3ba16e
      
https://github.com/qemu/qemu/commit/b8c5fdc6588f82d95807be0eb2215d215a3ba16e
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M docs/system/bootindex.rst

  Log Message:
  -----------
  docs/system/bootindex: Make it clear that s390x can also boot from virtio-net

Let's make it clear that s390x can also boot from virtio-net, to avoid
that people think that s390x can only boot from disk devices.

Reported-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Message-ID: <20241111105506.264640-1-thuth@redhat.com>
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6e7c96ae61e0542e97d385084f1f2281a0331054
      
https://github.com/qemu/qemu/commit/6e7c96ae61e0542e97d385084f1f2281a0331054
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M hw/s390x/ccw-device.c
    M hw/s390x/ccw-device.h
    M hw/s390x/virtio-ccw-blk.c
    M hw/s390x/virtio-ccw-net.c
    M hw/vfio/ccw.c

  Log Message:
  -----------
  hw/s390x: Restrict "loadparm" property to devices that can be used for booting

Commit bb185de423 ("s390x: Add individual loadparm assignment to
CCW device") added a "loadparm" property to all CCW devices. This
was a little bit unfortunate, since this property is only useful
for devices that can be used for booting, but certainly it is not
useful for devices like virtio-gpu or virtio-tablet.

Thus let's restrict the property to CCW devices that we can boot from
(i.e. virtio-block, virtio-net and vfio-ccw devices).

Message-ID: <20241113114741.681096-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Jared Rossi <jrossi@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: efd3dda312129b91986f85976afbda58d40f757f
      
https://github.com/qemu/qemu/commit/efd3dda312129b91986f85976afbda58d40f757f
  Author: Eric Blake <eblake@redhat.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd-server: Silence server warnings on port probes

While testing the use of qemu-nbd in a Pod of a Kubernetes cluster, I
got LOTS of log messages of the forms:

qemu-nbd: option negotiation failed: Failed to read flags: Unexpected 
end-of-file before all data were read
qemu-nbd: option negotiation failed: Failed to read flags: Unable to read from 
socket: Connection reset by peer

While it is nice to warn about clients that aren't following protocol
(in case it helps diagnosing bugs in those clients), a mere port probe
(where the client never write()s any bytes, and where we might even
hit EPIPE in trying to send our greeting to the client) is NOT
abnormal, but merely serves to pollute the log.  And Kubernetes
_really_ likes to do port probes to determine whether a given Pod is
up and running.

Easy ways to demonstrate the above port probes:
$ qemu-nbd -r -f raw path/to/file &
$ nc localhost 10809 </dev/null
$ bash -c 'exec </dev/tcp/localhost/10809'
$ kill $!

Silence the noise by not capturing errors until after our first
successful read() from a client.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-ID: <20241115195638.1132007-2-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 429442e52d94f890fa194a151e8cd649b04e9e63
      
https://github.com/qemu/qemu/commit/429442e52d94f890fa194a151e8cd649b04e9e63
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M hw/core/qdev-properties-system.c
    M hw/s390x/ipl.c
    M hw/scsi/scsi-disk.c
    M include/hw/qdev-properties-system.h

  Log Message:
  -----------
  hw: Add "loadparm" property to scsi disk devices for booting on s390x

While adding the new flexible boot order feature on s390x recently,
we missed to add the "loadparm" property to the scsi-hd and scsi-cd
devices. This property is required on s390x to pass the information
to the boot loader about which kernel should be started or whether
the boot menu should be shown. But even more serious: The missing
property is now causing trouble with the corresponding libvirt patches
that assume that the "loadparm" property is either settable for all
bootable devices (when the "boot order" feature is implemented in
QEMU), or none (meaning the behaviour of older QEMUs that only allowed
one "loadparm" at the machine level). To fix this broken situation,
let's implement the "loadparm" property in for the SCSI devices, too.

Message-ID: <20241115141202.1877294-1-thuth@redhat.com>
Acked-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8c797468116d19940fb758efa749eae414616e3a
      
https://github.com/qemu/qemu/commit/8c797468116d19940fb758efa749eae414616e3a
  Author: Jared Rossi <jrossi@linux.ibm.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M pc-bios/s390-ccw/main.c

  Log Message:
  -----------
  pc-bios/s390x: Initialize cdrom type to false for each IPL device

Clear information about cdrom type so that current IPL device isn't tainted
by stale data from previous devices.

Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20241108194136.2833932-1-jrossi@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1056ca1e70dc6e0458238141bcebfb7810cede6d
      
https://github.com/qemu/qemu/commit/1056ca1e70dc6e0458238141bcebfb7810cede6d
  Author: Jared Rossi <jrossi@linux.ibm.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M pc-bios/s390-ccw/main.c

  Log Message:
  -----------
  pc-bios/s390x: Initialize machine loadparm before probing IPL devices

Commit bb185de423 ("s390x: Add individual loadparm assignment to
CCW device") allowed boot devices to be assigned a loadparm value independent
of the machine value, however, when no boot devices are defined, the machine
loadparm becomes ignored. Therefore, let's check the machine loadparm
prior to probing the devices.

Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20241114161952.3508554-1-jrossi@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6ba1f714c00f8839a8df9f643e0058f00da3fd25
      
https://github.com/qemu/qemu/commit/6ba1f714c00f8839a8df9f643e0058f00da3fd25
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M pc-bios/s390-ccw/virtio-net.c

  Log Message:
  -----------
  pc-bios/s390-ccw: Re-initialize receive queue index before each boot attempt

Now that we can boot from multiple boot devices, we have to make sure
to reinitialize static variables like rx_last_idx to avoid that they
contain garbage data during the second boot attempt (which can lead to
crashes when the code tries to access the wrong ring data).

Message-ID: <20241111131120.317796-1-thuth@redhat.com>
Reviewed-by: Jared Rossi <jrossi@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8cf9190fc18ea46ad98f3132276e130c92188234
      
https://github.com/qemu/qemu/commit/8cf9190fc18ea46ad98f3132276e130c92188234
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M pc-bios/s390-ccw.img

  Log Message:
  -----------
  pc-bios: Update the s390 bios images with the recent fixes

Add the fixes from the previous three commits to the binary, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4483d98ab82671165276026b09287053328c94d4
      
https://github.com/qemu/qemu/commit/4483d98ab82671165276026b09287053328c94d4
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M .gitlab-ci.d/crossbuild-template.yml

  Log Message:
  -----------
  .gitlab-ci.d: Raise timeout on cross-accel build jobs to 60m

The current 30 minute timeout on the cross_accel_build_job template
is a bit low: sometimes if the k8s runners are running slow the
can hit it, for example this cross-arm64-xen-only job hit the
30 minute timeout while still not quite finished with the compile:
https://gitlab.com/qemu-project/qemu/-/jobs/8401277985

This is partly a "runner performance can be unpredictable" issue:
https://gitlab.com/qemu-project/qemu/-/jobs/8391726482
is the same job from just a day earlier and it finished in
16 minutes. But we already have build jobs that are higher
timeouts than 30 minutes, so we have headroom to raise the
timeout here to something we're less likely to hit on a slow
runner.

Bump the cross_accel_build_job timeout to 60 mins.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20241118153226.1524542-1-peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2c471a8291c182130a77702d9bd4c910d987c6a9
      
https://github.com/qemu/qemu/commit/2c471a8291c182130a77702d9bd4c910d987c6a9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M .gitlab-ci.d/crossbuild-template.yml
    M docs/system/bootindex.rst
    M docs/system/s390x/bootdevices.rst
    M fpu/softfloat-specialize.c.inc
    M hw/core/qdev-properties-system.c
    M hw/s390x/ccw-device.c
    M hw/s390x/ccw-device.h
    M hw/s390x/ipl.c
    M hw/s390x/virtio-ccw-blk.c
    M hw/s390x/virtio-ccw-net.c
    M hw/scsi/scsi-disk.c
    M hw/vfio/ccw.c
    M include/hw/qdev-properties-system.h
    M include/hw/usb/dwc2-regs.h
    M pc-bios/s390-ccw.img
    M pc-bios/s390-ccw/main.c
    M pc-bios/s390-ccw/virtio-net.c
    M target/s390x/tcg/fpu_helper.c
    M target/s390x/tcg/vec_fpu_helper.c
    M tests/tcg/s390x/Makefile.target
    A tests/tcg/s390x/float.h
    A tests/tcg/s390x/fma.c
    M tests/tcg/s390x/vfminmax.c

  Log Message:
  -----------
  Merge tag 'pull-request-2024-11-18' of https://gitlab.com/thuth/qemu into 
staging

* Fixes & doc updates for the new "boot order" s390x bios feature
* Provide a "loadparm" property for scsi-hd & scsi-cd devices on s390x
  (required for the "boot order" feature)
* Fix the floating-point multiply-and-add NaN rules on s390x
* Raise timeout on cross-accel build jobs to 60m

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmc7ercRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbVjyg//ZuhSDCj+oBSU6vwM7Lwh3CS6GwZvGECU
# h60V3tizKypiRNtTJRXHoWcx95brXmoZgI+QQhDEXe3fFLkOEKT6AIlDhrKZRUsd
# rpLPr6O8TVKO+rSE7JVJAP3X1tpOOQDxnq83uWBv53b0S+Da0VwDRtI9gcugRMmh
# d58P8Q1bV344fQdcrebejstpSUG7RxSA4Plj2uSQx4mSHT7cy/hN+vA34Ha7reE3
# tcN9yfQq3Rmfvt0MV5I9Umd6JXEoDlEAwjSNsWRsCzo69jBZwiMtXSH8LyLtwRTp
# C919G/MIRuhvImF74dStLVCr82sNq54YR1NP6CGcmqPH76FOH8Mx3vmx9Cxj9ckA
# 6NI6SvIg++bW2O1efG2apz8p5fjbDzYXSAbHnaWTcEu3gPgH4PQ5QXoyKaDymvWV
# JIh5/gXEy+twEXgIBsdWQ44A9E06lL/tNfKnqGdXK4ZYF2JIrI+Lq7AKBee7tebP
# +72I4PljHLSHQ3GxdkoOeJ8ahu70IBdSz2/VEIwOWK1wIf5C5WFNBerLJyDmkyx8
# xIvIm0vlRLwPcuOC711nlaMaKqTNT+8W4DIqIY6fHs2Jy0psMdgey1uHQxYEj9Kh
# fg7CvalK8n3MkGAwTqAvRJIwMFe0a4Ss6c6CaemSaYa38ud/pCNnv+IT+Eqr+mjq
# 6y5PZWNrZi0=
# =UaDH
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 18 Nov 2024 17:34:47 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2024-11-18' of https://gitlab.com/thuth/qemu:
  .gitlab-ci.d: Raise timeout on cross-accel build jobs to 60m
  pc-bios: Update the s390 bios images with the recent fixes
  pc-bios/s390-ccw: Re-initialize receive queue index before each boot attempt
  pc-bios/s390x: Initialize machine loadparm before probing IPL devices
  pc-bios/s390x: Initialize cdrom type to false for each IPL device
  hw: Add "loadparm" property to scsi disk devices for booting on s390x
  hw/s390x: Restrict "loadparm" property to devices that can be used for booting
  docs/system/bootindex: Make it clear that s390x can also boot from virtio-net
  docs/system/s390x/bootdevices: Update loadparm documentation
  tests/tcg/s390x: Add the floating-point multiply-and-add test
  target/s390x: Fix the floating-point multiply-and-add NaN rules
  hw/usb: Use __attribute__((packed)) vs __packed

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: af4c4fd128d3e73f7435a3723e9fcd2ec64c5f4c
      
https://github.com/qemu/qemu/commit/af4c4fd128d3e73f7435a3723e9fcd2ec64c5f4c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  Merge tag 'pull-nbd-2024-11-18' of https://repo.or.cz/qemu/ericb into staging

NBD patches for 2024-11-18

- Eric Blake: Silence qemu-nbd on harmless client port probes

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAmc7lg0ACgkQp6FrSiUn
# Q2qamgf/QJXHzF5koncXvpOC58QXthe1EQlTNqTv9lSz7GNif7UXtkv9RBMMqNEP
# 7MDY2L9LzlvMdTqXx6dndQot2YG+PSpqLFQxdjf7J3YUK5N6dQ/w4lCVI+tfVfYF
# DcYva7TBTfSWMByVdqYhnXc1nAn6liJfaaONf80y3wHObUu8T7qkMY/cb5njpjmT
# YPKyIJO7DX+ZNY5EZkFGntAxPge368nIrBsViYqst8kNWjtr8o2Rzc7fqa6sbBtw
# 47tiBDP6usBJb2kapOrpmC5zqHlbb56AbrIsTJ4Ge/iUOKrODtmCC4d7WWGSM3DC
# udaL74DOMgoMfVGjjaX9KW6Wv3/HFw==
# =DnNy
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 18 Nov 2024 19:31:25 GMT
# gpg:                using RSA key 71C2CC22B1C4602927D2F3AAA7A16B4A2527436A
# gpg: Good signature from "Eric Blake <eblake@redhat.com>" [full]
# gpg:                 aka "Eric Blake (Free Software Programmer) 
<ebb9@byu.net>" [full]
# gpg:                 aka "[jpeg image of size 6874]" [full]
# Primary key fingerprint: 71C2 CC22 B1C4 6029 27D2  F3AA A7A1 6B4A 2527 436A

* tag 'pull-nbd-2024-11-18' of https://repo.or.cz/qemu/ericb:
  nbd-server: Silence server warnings on port probes

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3428a3894c6f...af4c4fd128d3

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications