qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 16f680: vhost_net: fix assertion triggered by


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 16f680: vhost_net: fix assertion triggered by batch of hos...
Date: Thu, 28 Nov 2024 02:56:00 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 16f6804c460109e8b126cc710a0072f9f83bd230
      
https://github.com/qemu/qemu/commit/16f6804c460109e8b126cc710a0072f9f83bd230
  Author: zuoboqun <zuoboqun@baidu.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M hw/net/vhost_net.c

  Log Message:
  -----------
  vhost_net: fix assertion triggered by batch of host notifiers processing

When the backend of vhost_net restarts during the vm is running, vhost_net
is stopped and started. The virtio_device_grab_ioeventfd() fucntion in
vhost_net_enable_notifiers() will result in a call to
virtio_bus_set_host_notifier()(assign=false).

And now virtio_device_grab_ioeventfd() is batched in a single transaction
with virtio_bus_set_host_notifier()(assign=true).

This triggers the following assertion:

kvm_mem_ioeventfd_del: error deleting ioeventfd: Bad file descriptor

This patch moves virtio_device_grab_ioeventfd() out of the batch to fix
this problem.

To be noted that the for loop to release ioeventfd should start from i+1,
not i, because the i-th ioeventfd has already been released in
vhost_dev_disable_notifiers_nvqs().

Fixes: 6166799f6 ("vhost_net: configure all host notifiers in a single MR 
transaction")
Signed-off-by: Zuo Boqun <zuoboqun@baidu.com>
Reported-by: Gao Shiyuan <gaoshiyuan@baidu.com>

Message-Id: <20241115080312.3184-1-zuoboqun@baidu.com>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: ef5e7aeaa6e7a258798c1eff2f5c726504116609
      
https://github.com/qemu/qemu/commit/ef5e7aeaa6e7a258798c1eff2f5c726504116609
  Author: Salil Mehta <salil.mehta@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M tests/qtest/bios-tables-test-allowed-diff.h

  Log Message:
  -----------
  qtest: allow ACPI DSDT Table changes

list changed files in tests/qtest/bios-tables-test-allowed-diff.h

Message-ID: <20241106100047.18901c9d@imammedo.users.ipa.redhat.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20241112170258.2996640-2-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: cb36e2573a02da2a4d95bae71e4d2f1a746d8ee2
      
https://github.com/qemu/qemu/commit/cb36e2573a02da2a4d95bae71e4d2f1a746d8ee2
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M hw/acpi/cpu.c
    M include/hw/core/cpu.h

  Log Message:
  -----------
  Revert "hw/acpi: Update ACPI `_STA` method with QOM vCPU ACPI Hotplug states"

This reverts commit bf1ecc8dad6061914730a2a2d57af6b37c3a4f8d
which broke cpu hotplug in x86 after migration to older QEMU

Fixes: bf1ecc8dad606 (w/acpi: Update ACPI `_STA` method with QOM vCPU ACPI 
Hotplug states)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20241112170258.2996640-3-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: f2ba6ab6212b656179c4f4ce68ee74a500c409b0
      
https://github.com/qemu/qemu/commit/f2ba6ab6212b656179c4f4ce68ee74a500c409b0
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M hw/acpi/cpu.c
    M include/hw/core/cpu.h

  Log Message:
  -----------
  Revert "hw/acpi: Make CPUs ACPI `presence` conditional during vCPU hot-unplug"

This reverts commit 2d6cfbaf174b91dfa9a50065f7494634afb39c23.

The patch is supposed to be part of ARM CPU hotplug series and has not value
on its own without it. The series however is still in RFC stage and outside
of scope 9.2 release.

On top of that it introduces not needed callback that pokes directly into
CPU state without any need for that. Instead properties and AML generator
option should be used to configure static platform depended vCPU presence
state.

Drop the patch so that corrected version could be posted along with
ARM CPU hotplug series and properly reviewed in relevant context.
That also helps us to keep history cleaner with new patch being
against original code vs a string of fixups on top of current mess.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20241112170258.2996640-4-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: e50a24ead1c0b39673060aa90466ab8ef246297f
      
https://github.com/qemu/qemu/commit/e50a24ead1c0b39673060aa90466ab8ef246297f
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M tests/data/acpi/x86/pc/DSDT
    M tests/data/acpi/x86/pc/DSDT.acpierst
    M tests/data/acpi/x86/pc/DSDT.acpihmat
    M tests/data/acpi/x86/pc/DSDT.bridge
    M tests/data/acpi/x86/pc/DSDT.cphp
    M tests/data/acpi/x86/pc/DSDT.dimmpxm
    M tests/data/acpi/x86/pc/DSDT.hpbridge
    M tests/data/acpi/x86/pc/DSDT.hpbrroot
    M tests/data/acpi/x86/pc/DSDT.ipmikcs
    M tests/data/acpi/x86/pc/DSDT.memhp
    M tests/data/acpi/x86/pc/DSDT.nohpet
    M tests/data/acpi/x86/pc/DSDT.numamem
    M tests/data/acpi/x86/pc/DSDT.roothp
    M tests/data/acpi/x86/q35/DSDT
    M tests/data/acpi/x86/q35/DSDT.acpierst
    M tests/data/acpi/x86/q35/DSDT.acpihmat
    M tests/data/acpi/x86/q35/DSDT.acpihmat-noinitiator
    M tests/data/acpi/x86/q35/DSDT.applesmc
    M tests/data/acpi/x86/q35/DSDT.bridge
    M tests/data/acpi/x86/q35/DSDT.core-count
    M tests/data/acpi/x86/q35/DSDT.core-count2
    M tests/data/acpi/x86/q35/DSDT.cphp
    M tests/data/acpi/x86/q35/DSDT.cxl
    M tests/data/acpi/x86/q35/DSDT.dimmpxm
    M tests/data/acpi/x86/q35/DSDT.ipmibt
    M tests/data/acpi/x86/q35/DSDT.ipmismbus
    M tests/data/acpi/x86/q35/DSDT.ivrs
    M tests/data/acpi/x86/q35/DSDT.memhp
    M tests/data/acpi/x86/q35/DSDT.mmio64
    M tests/data/acpi/x86/q35/DSDT.multi-bridge
    M tests/data/acpi/x86/q35/DSDT.noacpihp
    M tests/data/acpi/x86/q35/DSDT.nohpet
    M tests/data/acpi/x86/q35/DSDT.numamem
    M tests/data/acpi/x86/q35/DSDT.pvpanic-isa
    M tests/data/acpi/x86/q35/DSDT.thread-count
    M tests/data/acpi/x86/q35/DSDT.thread-count2
    M tests/data/acpi/x86/q35/DSDT.tis.tpm12
    M tests/data/acpi/x86/q35/DSDT.tis.tpm2
    M tests/data/acpi/x86/q35/DSDT.type4-count
    M tests/data/acpi/x86/q35/DSDT.viot
    M tests/data/acpi/x86/q35/DSDT.xapic
    M tests/qtest/bios-tables-test-allowed-diff.h

  Log Message:
  -----------
  tests/acpi: update expected blobs

Expected AML return to the state before
  bf1ecc8dad606 (w/acpi: Update ACPI `_STA` method with QOM vCPU ACPI Hotplug 
states)
droping not needed CPRS and _STA logic that broke cpu hotplug

        @@ -2887,7 +2887,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC   
 ", 0x00000001)
                         CRMV,   1,
                         CEJ0,   1,
                         CEJF,   1,
        -                CPRS,   1,
                         Offset (0x05),
                         CCMD,   8
                     }
        @@ -2922,16 +2921,9 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC  
  ", 0x00000001)
                         Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)
                         \_SB.PCI0.PRES.CSEL = Arg0
                         Local0 = Zero
        -                If ((\_SB.PCI0.PRES.CPRS == One))
        +                If ((\_SB.PCI0.PRES.CPEN == One))
                         {
        -                    If ((\_SB.PCI0.PRES.CPEN == One))
        -                    {
        -                        Local0 = 0x0F
        -                    }
        -                    Else
        -                    {
        -                        Local0 = 0x0D
        -                    }
        +                    Local0 = 0x0F
                         }

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20241112170258.2996640-5-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: c5e36a5a6adbab7f6dc17d3bcb7b06660995cdc3
      
https://github.com/qemu/qemu/commit/c5e36a5a6adbab7f6dc17d3bcb7b06660995cdc3
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M hw/cxl/cxl-mailbox-utils.c

  Log Message:
  -----------
  hw/cxl: Check for zero length features in cmd_features_set_feature()

Zero length data for features doesn't make any sense so exclude that case
early. This fixes the undefined behavior reported by coverity for a zero
length memcpy().

Resolves CID 1564900 and 1564901

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20241108175814.1248278-1-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: e069c115e00d9eeb1ad6bf224775585c3d30177d
      
https://github.com/qemu/qemu/commit/e069c115e00d9eeb1ad6bf224775585c3d30177d
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M qapi/qdev.json

  Log Message:
  -----------
  qapi: fix device-sync-config since-version

Actually it comes in 9.2, not 9.1.

Fixes: 3f98408e2e ("qapi: introduce device-sync-config")
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20241108071957.727286-1-vsementsov@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 13a4a6ba2bfd3cf9bd34a015929d93868d792de8
      
https://github.com/qemu/qemu/commit/13a4a6ba2bfd3cf9bd34a015929d93868d792de8
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M hw/acpi/aml-build.c

  Log Message:
  -----------
  hw/acpi: Fix size of HID in build_append_srat_acpi_device_handle()

The size should always be 8 so hard code that. By coincidience the
incorrect use of sizeof(char *) is 8 on 64 bit hosts, but was caught
by CI testing with i686 as the host.

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Closes: 
https://lore.kernel.org/qemu-devel/20241104110025-mutt-send-email-mst@kernel.org/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20241107123446.902801-2-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 37a14f24b4ee696def42d7629598ab6da7399f65
      
https://github.com/qemu/qemu/commit/37a14f24b4ee696def42d7629598ab6da7399f65
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M qapi/qom.json

  Log Message:
  -----------
  qapi/qom: Change Since entry for AcpiGenericPortProperties to 9.2

This feature was only applied during the 9.2 cycle, so reflect
that rather than 9.1.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Closes: https://lore.kernel.org/qemu-devel/ZyngEiwmYeZ-DvCy@redhat.com/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20241107123446.902801-3-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 2cb740932c567b57f6f51c9ead036a1d31d3e620
      
https://github.com/qemu/qemu/commit/2cb740932c567b57f6f51c9ead036a1d31d3e620
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    A tests/data/acpi/x86/q35/APIC.acpihmat-generic-x
    A tests/data/acpi/x86/q35/CEDT.acpihmat-generic-x
    A tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x
    A tests/data/acpi/x86/q35/HMAT.acpihmat-generic-x
    A tests/data/acpi/x86/q35/SRAT.acpihmat-generic-x
    M tests/qtest/bios-tables-test-allowed-diff.h

  Log Message:
  -----------
  bios-tables-test: Allow for new acpihmat-generic-x test data.

The test to be added exercises many corner cases of the SRAT and HMAT table
generation.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20241107123446.902801-4-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 18afed7402038b772dc9e9250181bcaddda864ab
      
https://github.com/qemu/qemu/commit/18afed7402038b772dc9e9250181bcaddda864ab
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  bios-tables-test: Add complex SRAT / HMAT test for GI GP

Add a test with 6 nodes to exercise most interesting corner cases of SRAT
and HMAT generation including the new Generic Initiator and Generic Port
Affinity structures.  More details of the set up in the following patch
adding the table data.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20241107123446.902801-5-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 5d525294626ebdc2741c19167217ec79a6c2cc08
      
https://github.com/qemu/qemu/commit/5d525294626ebdc2741c19167217ec79a6c2cc08
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M tests/data/acpi/x86/q35/APIC.acpihmat-generic-x
    M tests/data/acpi/x86/q35/CEDT.acpihmat-generic-x
    M tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x
    M tests/data/acpi/x86/q35/HMAT.acpihmat-generic-x
    M tests/data/acpi/x86/q35/SRAT.acpihmat-generic-x
    M tests/qtest/bios-tables-test-allowed-diff.h

  Log Message:
  -----------
  bios-tables-test: Add data for complex numa test (GI, GP etc)

Given this is a new configuration, there are affects on APIC, CEDT
and DSDT, but the key elements are in SRAT (plus related data in
HMAT).  The configuration has node to exercise many different combinations.

0) CPUs + Memory
1) GI only
2) GP only
3) CPUS only
4) Memory only
5) CPUs + HP memory

GI node, GP Node, Memory only node, hotplug memory
only node, latency and bandwidth such that in Linux Access0
(any initiator) and Access1 (CPU initiators only) given different
answers.  Following cropped to remove details of each entry.

[000h 0000 004h]                   Signature : "SRAT"    [System Resource 
Affinity Table]
...
[030h 0048 001h]               Subtable Type : 00 [Processor Local APIC/SAPIC 
Affinity]
...
[032h 0050 001h]     Proximity Domain Low(8) : 00
[033h 0051 001h]                     Apic ID : 00
...
[040h 0064 001h]               Subtable Type : 00 [Processor Local APIC/SAPIC 
Affinity]
...
[042h 0066 001h]     Proximity Domain Low(8) : 03
[043h 0067 001h]                     Apic ID : 01
...
[050h 0080 001h]               Subtable Type : 00 [Processor Local APIC/SAPIC 
Affinity]
...
[052h 0082 001h]     Proximity Domain Low(8) : 05
[053h 0083 001h]                     Apic ID : 02
...
[060h 0096 001h]               Subtable Type : 01 [Memory Affinity]
...
[062h 0098 004h]            Proximity Domain : 00000000
...
[068h 0104 008h]                Base Address : 0000000000000000
[070h 0112 008h]              Address Length : 00000000000A0000
...
[088h 0136 001h]               Subtable Type : 01 [Memory Affinity]
...
[08Ah 0138 004h]            Proximity Domain : 00000000
...
[090h 0144 008h]                Base Address : 0000000000100000
[098h 0152 008h]              Address Length : 0000000003F00000
...
[0B0h 0176 001h]               Subtable Type : 01 [Memory Affinity]
...
[0B2h 0178 004h]            Proximity Domain : 00000004
...
[0B8h 0184 008h]                Base Address : 0000000004000000
[0C0h 0192 008h]              Address Length : 0000000004000000
... some zero length entries follow...

[1A0h 0416 001h]               Subtable Type : 05 [Generic Initiator Affinity]
[1A1h 0417 001h]                      Length : 20

[1A2h 0418 001h]                   Reserved1 : 00
[1A3h 0419 001h]          Device Handle Type : 01
[1A4h 0420 004h]            Proximity Domain : 00000001
[1A8h 0424 010h]               Device Handle : 00 00 01 02 00 00 00 00 00 00 00 
00 00 00 00 00
[1B8h 0440 004h]       Flags (decoded below) : 00000001
                                     Enabled : 1
                  Architectural Transactions : 0
[1BCh 0444 004h]                   Reserved2 : 00000000

[1C0h 0448 001h]               Subtable Type : 06 [Generic Port Affinity]
[1C1h 0449 001h]                      Length : 20

[1C2h 0450 001h]                   Reserved1 : 00
[1C3h 0451 001h]          Device Handle Type : 00
[1C4h 0452 004h]            Proximity Domain : 00000002
[1C8h 0456 010h]               Device Handle : 41 43 50 49 30 30 31 36 40 00 00 
00 00 00 00 00
[1D8h 0472 004h]       Flags (decoded below) : 00000001
                                     Enabled : 1
                  Architectural Transactions : 0
[1DCh 0476 004h]                   Reserved2 : 00000000

[1E0h 0480 001h]               Subtable Type : 01 [Memory Affinity]
...
[1E2h 0482 004h]            Proximity Domain : 00000005
...
[1E8h 0488 008h]                Base Address : 0000000100000000
[1F0h 0496 008h]              Address Length : 0000000090000000

Example block from HMAT:
[0F0h 0240 002h]              Structure Type : 0001 [System Locality Latency 
and Bandwidth Information]
[0F2h 0242 002h]                    Reserved : 0000
[0F4h 0244 004h]                      Length : 00000078
[0F8h 0248 001h]       Flags (decoded below) : 00
                            Memory Hierarchy : 0
                   Use Minimum Transfer Size : 0
                    Non-sequential Transfers : 0
[0F9h 0249 001h]                   Data Type : 03
[0FAh 0250 001h]       Minimum Transfer Size : 00
[0FBh 0251 001h]                   Reserved1 : 00
[0FCh 0252 004h] Initiator Proximity Domains # : 00000004
[100h 0256 004h]  Target Proximity Domains # : 00000006
[104h 0260 004h]                   Reserved2 : 00000000
[108h 0264 008h]             Entry Base Unit : 0000000000000004
[110h 0272 004h] Initiator Proximity Domain List : 00000000
[114h 0276 004h] Initiator Proximity Domain List : 00000001
[118h 0280 004h] Initiator Proximity Domain List : 00000003
[11Ch 0284 004h] Initiator Proximity Domain List : 00000005
[120h 0288 004h] Target Proximity Domain List : 00000000
[124h 0292 004h] Target Proximity Domain List : 00000001
[128h 0296 004h] Target Proximity Domain List : 00000002
[12Ch 0300 004h] Target Proximity Domain List : 00000003
[130h 0304 004h] Target Proximity Domain List : 00000004
[134h 0308 004h] Target Proximity Domain List : 00000005
[138h 0312 002h]                       Entry : 00C8
[13Ah 0314 002h]                       Entry : 0000
[13Ch 0316 002h]                       Entry : 0032
[13Eh 0318 002h]                       Entry : 0000
[140h 0320 002h]                       Entry : 0032
[142h 0322 002h]                       Entry : 0064
[144h 0324 002h]                       Entry : 0019
[146h 0326 002h]                       Entry : 0000
[148h 0328 002h]                       Entry : 0064
[14Ah 0330 002h]                       Entry : 0000
[14Ch 0332 002h]                       Entry : 00C8
[14Eh 0334 002h]                       Entry : 0019
[150h 0336 002h]                       Entry : 0064
[152h 0338 002h]                       Entry : 0000
[154h 0340 002h]                       Entry : 0032
[156h 0342 002h]                       Entry : 0000
[158h 0344 002h]                       Entry : 0032
[15Ah 0346 002h]                       Entry : 0064
[15Ch 0348 002h]                       Entry : 0064
[15Eh 0350 002h]                       Entry : 0000
[160h 0352 002h]                       Entry : 0032
[162h 0354 002h]                       Entry : 0000
[164h 0356 002h]                       Entry : 0032
[166h 0358 002h]                       Entry : 00C8

Note the zeros represent entries where the target node has no
memory.  These could be surpressed but it isn't 'wrong' to provide
them and it is (probably) permissible under ACPI to hotplug memory
into these nodes later.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Message-Id: <20241107123446.902801-6-Jonathan.Cameron@huawei.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 571bdc97b83646dfd3746ec56fb2f70bca55b9a2
      
https://github.com/qemu/qemu/commit/571bdc97b83646dfd3746ec56fb2f70bca55b9a2
  Author: Prasad Pandit <pjp@fedoraproject.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M hw/virtio/vhost.c

  Log Message:
  -----------
  vhost: fail device start if iotlb update fails

While starting a vhost device, updating iotlb entries
via 'vhost_device_iotlb_miss' may return an error.

  qemu-kvm: vhost_device_iotlb_miss:
    700871,700871: Fail to update device iotlb

Fail device start when such an error occurs.

Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
Message-Id: <20241107113247.46532-1-ppandit@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>


  Commit: 24602b77f5658ae8377958c15fdef2f44affc743
      
https://github.com/qemu/qemu/commit/24602b77f5658ae8377958c15fdef2f44affc743
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M hw/acpi/aml-build.c
    M hw/acpi/cpu.c
    M hw/cxl/cxl-mailbox-utils.c
    M hw/net/vhost_net.c
    M hw/virtio/vhost.c
    M include/hw/core/cpu.h
    M qapi/qdev.json
    M qapi/qom.json
    M tests/data/acpi/x86/pc/DSDT
    M tests/data/acpi/x86/pc/DSDT.acpierst
    M tests/data/acpi/x86/pc/DSDT.acpihmat
    M tests/data/acpi/x86/pc/DSDT.bridge
    M tests/data/acpi/x86/pc/DSDT.cphp
    M tests/data/acpi/x86/pc/DSDT.dimmpxm
    M tests/data/acpi/x86/pc/DSDT.hpbridge
    M tests/data/acpi/x86/pc/DSDT.hpbrroot
    M tests/data/acpi/x86/pc/DSDT.ipmikcs
    M tests/data/acpi/x86/pc/DSDT.memhp
    M tests/data/acpi/x86/pc/DSDT.nohpet
    M tests/data/acpi/x86/pc/DSDT.numamem
    M tests/data/acpi/x86/pc/DSDT.roothp
    A tests/data/acpi/x86/q35/APIC.acpihmat-generic-x
    A tests/data/acpi/x86/q35/CEDT.acpihmat-generic-x
    M tests/data/acpi/x86/q35/DSDT
    M tests/data/acpi/x86/q35/DSDT.acpierst
    M tests/data/acpi/x86/q35/DSDT.acpihmat
    A tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x
    M tests/data/acpi/x86/q35/DSDT.acpihmat-noinitiator
    M tests/data/acpi/x86/q35/DSDT.applesmc
    M tests/data/acpi/x86/q35/DSDT.bridge
    M tests/data/acpi/x86/q35/DSDT.core-count
    M tests/data/acpi/x86/q35/DSDT.core-count2
    M tests/data/acpi/x86/q35/DSDT.cphp
    M tests/data/acpi/x86/q35/DSDT.cxl
    M tests/data/acpi/x86/q35/DSDT.dimmpxm
    M tests/data/acpi/x86/q35/DSDT.ipmibt
    M tests/data/acpi/x86/q35/DSDT.ipmismbus
    M tests/data/acpi/x86/q35/DSDT.ivrs
    M tests/data/acpi/x86/q35/DSDT.memhp
    M tests/data/acpi/x86/q35/DSDT.mmio64
    M tests/data/acpi/x86/q35/DSDT.multi-bridge
    M tests/data/acpi/x86/q35/DSDT.noacpihp
    M tests/data/acpi/x86/q35/DSDT.nohpet
    M tests/data/acpi/x86/q35/DSDT.numamem
    M tests/data/acpi/x86/q35/DSDT.pvpanic-isa
    M tests/data/acpi/x86/q35/DSDT.thread-count
    M tests/data/acpi/x86/q35/DSDT.thread-count2
    M tests/data/acpi/x86/q35/DSDT.tis.tpm12
    M tests/data/acpi/x86/q35/DSDT.tis.tpm2
    M tests/data/acpi/x86/q35/DSDT.type4-count
    M tests/data/acpi/x86/q35/DSDT.viot
    M tests/data/acpi/x86/q35/DSDT.xapic
    A tests/data/acpi/x86/q35/HMAT.acpihmat-generic-x
    A tests/data/acpi/x86/q35/SRAT.acpihmat-generic-x
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu 
into staging

virtio,pc,pci: bug fixes, new test

Some small bug fixes, notably a fix for a regression
in cpu hotplug after migration. I also included a
new test, just to help make sure we don't regress cxl.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

# -----BEGIN PGP SIGNATURE-----
#
# iQFDBAABCAAtFiEEXQn9CHHI+FuUyooNKB8NuNKNVGkFAmdHJRIPHG1zdEByZWRo
# YXQuY29tAAoJECgfDbjSjVRpTkQIAJYFpFTPRnO8mA6gurfheB7Jt0ywAMrjKWfg
# uEkfZXXSQeCS8NBNPoZt7S8AE6xHE2a4b5lNWiS4a4coFmgTjtKPM8YsU01riyRk
# EasRxynGua2XGUWGK93r9L27v9zGz/vRC0Lujmw3VAUKGeL7a17KzmxwXLXe+DzS
# PgcI/H5hqoCDalT8aF6wOEDaWIHeo4dauDubYavW/+yaPtUvmy9MBkXbIV4iYqT5
# V6geeYIKW/yE/GHxxXOw/RE1FgpiZhebtQP26jPTSk0z/JaV5S0DNYs07joXmbaU
# fW5LSLgH3+oDI/GIhvsZ6hP87rVXBdaAogeJqT8SsuChBR55TpY=
# =B7KB
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 27 Nov 2024 13:56:34 GMT
# gpg:                using RSA key 5D09FD0871C8F85B94CA8A0D281F0DB8D28D5469
# gpg:                issuer "mst@redhat.com"
# gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>" [full]
# gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>" [full]
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu:
  vhost: fail device start if iotlb update fails
  bios-tables-test: Add data for complex numa test (GI, GP etc)
  bios-tables-test: Add complex SRAT / HMAT test for GI GP
  bios-tables-test: Allow for new acpihmat-generic-x test data.
  qapi/qom: Change Since entry for AcpiGenericPortProperties to 9.2
  hw/acpi: Fix size of HID in build_append_srat_acpi_device_handle()
  qapi: fix device-sync-config since-version
  hw/cxl: Check for zero length features in cmd_features_set_feature()
  tests/acpi: update expected blobs
  Revert "hw/acpi: Make CPUs ACPI `presence` conditional during vCPU hot-unplug"
  Revert "hw/acpi: Update ACPI `_STA` method with QOM vCPU ACPI Hotplug states"
  qtest: allow ACPI DSDT Table changes
  vhost_net: fix assertion triggered by batch of host notifiers processing

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/45069ea30722...24602b77f565

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]