[Qemu-devel] Re: Re: [4476] musicpal: Improve button handling (JanKiszka).

[consul]

"Paul Brook" <address@hidden> wrote in message 
news:address@hidden

>> Surely this should be in osdep.h as a conditional definition of sleep.
>
> The real bug is that we're using sleep() in the first place :-)
>

IMHO committed code should at least compile on all supported platforms. Even 
a temporary fix is better than no fix at all. Using the sleep is certainly 
not the best solution and Jan already proposed another patch without it, see 
[RFC][PATCH 2/2] MusicPal: Add specific -hold-buttonoption, without the 
sleep function, but as of today, the latest qemu svn (4511) does not compile 
on Windows, and that's a real bug.

Alex.