Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too.

[Blue Swirl]

On 5/27/08, Fabrice Bellard <address@hidden> wrote:
> Glauber Costa wrote:
>
> > Unlike other architectures, i386 lacked a "halted" attribute, going
> > with a flag into hflags. By using the halted attribute, we can make
> > the code look like more other architectures, and simplify the code in
> > some instances. In this commit, we make the code for info_cpus simpler
> > in monitor.c
> >
>
>  Good for the I386 halted attribute, as it was a mistake to put in in the
> hflags. For the memory, hflags should contain only parts of the CPU state
> known at translation time and should be equal to tb->flags. Most CPUs
> (including x86 !) do not follow this sane rule.
>
>  For cpu_info_ip, it would be simpler to return an uint64_t containing the
> PC. I don't think the sparc case with npc really matters.

It's not very likely that the NPC would be different for some value of
PC when halted, but it's still nice.