[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] osdep.c patch (FreeBSD hosts)
From: |
Juergen Lock |
Subject: |
Re: [Qemu-devel] osdep.c patch (FreeBSD hosts) |
Date: |
Fri, 30 May 2008 01:03:05 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Fri, May 30, 2008 at 12:57:13AM +0200, Juergen Lock wrote:
> On Thu, May 29, 2008 at 11:54:31PM +0200, Fabrice Bellard wrote:
> > Is it really needed to mmap() the RAM on FreeBSD ? This is a Linux
> > specific hack, and it may even be obsolete with recent Linux kernels.
> >
> Hmm actually I don't know... You think the...
>
> > > +#else
> > > + ptr = mmap(NULL,
> > > + size,
> > > + PROT_WRITE | PROT_READ, MAP_PRIVATE|MAP_ANON,
> > > + -1, 0);
> > > +#endif
>
> could be replaced by just malloc? Or would there be align issues too?
..and I just checked the manpage, our malloc page-aligns too (for sizes >=
pagesize), so at least that shouldn't be an issue.
Juergen