qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] build system: Further improve quiet mode


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode
Date: Mon, 26 Jan 2009 19:08:20 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Anthony Liguori wrote:
> 
>> Derived from Stuart Brady's patch: Show the target directory as prefix
>> to the current module when building in quiet mode. This helps to gain
>> overview of the current build progress, specifically when running
>> parallelized builds.
>>
>> Furthermore, suppress make command echoing when entering subdirs and
>> replace $(subst subdir-,,$@) with $* in the related rule.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
> Applied.  Thanks.
> 
> The output really does look better.
> 

Accidentally missed -v2? If yes, here is the delta:

------>

Add-on to the previous patch: On request by Laurent Desnogues dump the
used CFLAGS and LDFLAGS once on startup of the quiet mode.

Signed-off-by: Jan Kiszka <address@hidden>
---

 Makefile  |    5 ++++-
 rules.mak |    2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4f7a55a..6a7db93 100644
--- a/Makefile
+++ b/Makefile
@@ -34,7 +34,10 @@ ifdef CONFIG_WIN32
 LIBS+=-lwinmm -lws2_32 -liphlpapi
 endif
 
-all: $(TOOLS) $(DOCS) recurse-all
+all:
+       $(call quiet-command,$(MAKE) build-all,"Building with\n  CFLAGS  = 
$(CFLAGS)\n  LDFLAGS = $(LDFLAGS)")
+
+build-all: $(TOOLS) $(DOCS) recurse-all
 
 SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
 
diff --git a/rules.mak b/rules.mak
index a75a93b..10e21ec 100644
--- a/rules.mak
+++ b/rules.mak
@@ -16,4 +16,4 @@ LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ 
$(LIBS),"  LINK  $(TARGET_
 %.a:
        $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,"  AR    
$(TARGET_DIR)$@")
 
-quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
+quiet-command = $(if $(V),$1,$(if $(2),@echo -e $2 && $1, @$1))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]