[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] CODING_STYLE: don't allow non-indented statements a
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PATCH] CODING_STYLE: don't allow non-indented statements after if/else blocks |
Date: |
Mon, 26 Oct 2009 07:26:37 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Rationale: The following code is difficult to read, but allowed by the
current coding style.
if (a == 5) printf("a was 5.\n");
else if (a == 6) printf("a was 6.\n");
else printf("a was something else entirely.\n");
Signed-off-by: Aurelien Jarno <address@hidden>
---
CODING_STYLE | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index a579cb1..3ffbc3d 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -51,11 +51,11 @@ QEMU coding style.
4. Block structure
-Every indented statement is braced; even if the block contains just one
-statement. The opening brace is on the line that contains the control
-flow statement that introduces the new block; the closing brace is on the
-same line as the else keyword, or on a line by itself if there is no else
-keyword. Example:
+Every control flow statement is followed by a new indented and braced
+block; even if the block contains just one statement. The opening brace
+is on the line that contains the control flow statement that introduces
+the new block; the closing brace is on the same line as the else keyword,
+or on a line by itself if there is no else keyword. Example:
if (a == 5) {
printf("a was 5.\n");
--
1.6.1.3
- [Qemu-devel] [PATCH] CODING_STYLE: don't allow non-indented statements after if/else blocks,
Aurelien Jarno <=