[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [trivial one-liner] be more specific in -mem-path error
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages |
Date: |
Sat, 27 Mar 2010 13:33:50 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Mar 16, 2010 at 11:01:46AM +0300, Michael Tokarev wrote:
> The error message qemu gives when hugetlbfs is not
> accessible is cryptic at best:
>
> mkstemp: Permission denied
>
> Make it a bit more specific instead:
>
> unable to create backing store for hugepages: Permission denied
>
> Thanks!
It looks good, but needs a Signed-off-by: line.
> /mjt
>
> diff --git a/exec.c b/exec.c
> index 891e0ee..985bdde 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2569,5 +2569,5 @@ static void *file_ram_alloc(ram_addr_t memory, const
> char *path)
> fd = mkstemp(filename);
> if (fd < 0) {
> - perror("mkstemp");
> + perror("unable to create backing store for hugepages");
> free(filename);
> return NULL;
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net