[Qemu-devel] [Bug 588748] Re: QEMU fails to boot DR DOS Plus since 0.6.1

[Anthony Liguori]

This patch doesn't seem correct as the spec is pretty clear that THRE
interrupt enable is set to high, then an interrupt is rased if
LSR.THRE=1.  Does the following also make DOSPlus boot again:


diff --git a/hw/serial.c b/hw/serial.c
index 9102edb..b0ac52f 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -401,7 +401,8 @@ static void serial_ioport_write(void *opaque, uint32_t addr,
                      s->poll_msl = 0;
                 }
             }
-            if (s->lsr & UART_LSR_THRE) {
+            if (s->ier & UART_IER_THRI &&
+                s->lsr & UART_LSR_THRE) {
                 s->thr_ipending = 1;
                 serial_update_irq(s);
             }


** Changed in: qemu
       Status: New => In Progress

-- 
QEMU fails to boot DR DOS Plus since 0.6.1
https://bugs.launchpad.net/bugs/588748
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: In Progress

Bug description:
The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents booting Digital 
Research DOS Plus.