[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] give some useful error messages when tap open
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] give some useful error messages when tap open |
Date: |
Thu, 03 Jun 2010 09:07:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Wed, 02 Jun 2010 20:26:58 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>>
>> > From: Michael Tokarev <address@hidden>
>> >
>> > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
>> > (with fprintf) something like this:
>> >
>> > warning: could not open /dev/net/tun: no virtual network emulation
>> >
>> > this has 2 issues:
>> > 1) it is not a warning really, it's a fatal error (kvm exits after
>> > that),
>> > 2) there's no indication as of what's actually wrong: printing errno there
>> > is helpful.
>> >
>> > The patch below removes the "warning" prefix, uses %m (since it's linux,
>> > %m is available as format modifier), and changes fprintf() to
>> > %qemu_error().
>>
>> To error_report(), you mean.
>
> It's the original commit log.. Should this be fixed? If so, Michael,
> could you resend?
Or maybe it could be fixed up on commit.
[...]