[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation
From: |
Miguel Di Ciurcio Filho |
Subject: |
[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation |
Date: |
Mon, 7 Jun 2010 16:39:05 -0300 |
On Mon, Jun 7, 2010 at 11:48 AM, Anthony Liguori <address@hidden> wrote:
>>
>> How about this small draft:
>>
>> Possible values for "type": tap, user, vde and socket. The 'info'
>> object contains all the parameters available via -netdev type,args.
>>
>> Notice: vlan is still there, unless the support for it is removed, IMHO.
>>
>
> 'id' is missing. Really, s/device/id/ is probably the right thing to do.
>
Following this logic, shouldn't query-block do the same?
-> { "execute": "query-block" }
<- {
"return":[
{
"device":"ide0-hd0",
"locked":false,
"removable":false,
"inserted":{
"ro":false,
"drv":"qcow2",
"encrypted":false,
"file":"disks/test.img"
},
"type":"hd"
},
I actually decided to use 'device' after looking at query-block, to
keep things more uniform. I'm just an student :-D
> vlan's are a totally separate concept. info netdev shouldn't return vlan
> devices IMHO. We should have a separate info vlan command that shows the
> vlan topology.
>
As Markus said, if qemu supports the old vlan thing, the information
should be there. The 'vlan' attribute will be optional in the
specification anyway.
A different command to list the devices grouped by vlan is indeed a good idea.
Regards,
Miguel