|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals |
Date: | Thu, 10 Jun 2010 12:14:36 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 06/09/2010 09:59 PM, Blue Swirl wrote:
struct APICState { - CPUState *cpu_env; + void *cpu_env;I proposed having an opaque CPUState type in hw/ but it was rejected. But I don't think using a void pointer is any better.It's not necessary for the patch. Maybe it's possible to avoid all CPUState references in apic.c by pushing the dependencies to pc.c. It could affect performance though.
I think it's unnecessary. But I'd leave CPUState Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |