[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query
From: |
Miguel Di Ciurcio Filho |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev |
Date: |
Fri, 11 Jun 2010 08:47:08 -0300 |
On Fri, Jun 11, 2010 at 8:37 AM, Markus Armbruster <address@hidden> wrote:
>> +- "id": the device's ID, must be unique (json-string)
>> +- "vlan": QEMU's internal vlan identification. Only present if the device is
>> + attached to a VLAN (json-int, optional)
>> +- "peer": ID of the frontend device when on a 1:1 relationship (json-string,
>> + optional)
>> +- "info": json-object containing the configuration information about the
>> device.
>
> Didn't we agree to have two separate query commands, one for net devices
> on VLANs, and another one for the rest?
>
There were no consensus or requirement about that on the previous thread.
>> +
>> +Note: The supported device information is the same one supported by the
>> '-net'
>> +command-line argument, which are listed in the '-help' output or QEMU's
>> manual.
>
> Not sure a pointer to -help suffices here.
>
Various parts of the documentation have the same structure: e.g.:
netdev_add. If it is really necessary, I could send a new version
without just a pointer to -help.
Regards,
Miguel
- [Qemu-devel] [PATCH 0/8] QMP: Introduce query-netdev, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 1/8] QObject API: introduce qdict_to_qstring() function, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 3/8] net: Introduce VLANClientState->info_dict, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 4/8] net: tap/tap-win32: introduce info_dict, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 5/8] net: vde: introduce info_dict, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 6/8] net: socket: introduce info_dict, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 7/8] net: slirp: introduce info_dict, Miguel Di Ciurcio Filho, 2010/06/10
- [Qemu-devel] [PATCH 8/8] monitor/net: introduce 'info netdev' with QMP support, Miguel Di Ciurcio Filho, 2010/06/10