[Qemu-devel] Re: [PATCH v3 3/5] QMP: Introduce MIGRATION events

[Luiz Capitulino]

On Thu, 10 Jun 2010 12:33:42 +0200
Juan Quintela <address@hidden> wrote:

> Luiz Capitulino <address@hidden> wrote:
> > On Wed,  9 Jun 2010 14:10:56 +0200
> > Juan Quintela <address@hidden> wrote:
> 
> >> +MIGRATION_FAILED
> >> +----------------
> >> +
> >> +Emitted when migration fails (both is source and target).  Notice
> >> +that this event will be changed for 0.14 when we have infrastructure
> >> +to emit a QError when things fail.
> >
> >  This is not the kind of information this file should have, compatible
> > changes should be noted when time comes and incompatible ones are just
> > forbidden after 0.13.
> 
> Then how you express that this value is going to have a QError in it on
> the future?

 We don't have to, the doc's purpose is to describe the current state of
the protocol. There might be exceptions, but in this case the change is
compatible and extending the protocol is something that is going to happen
at every release.

 The doc will be updated when the change is introduced.

> Adding a Default QError that puts 'This QError is going to be refined'
> or what?

 We only have to do something like that if having the error information is
something needed right now, which is the case of the BLOCK_IO_ERROR event.