[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: delete QemuOpts when net_client_init() fai
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] net: delete QemuOpts when net_client_init() fails. |
Date: |
Mon, 21 Jun 2010 10:28:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Yoshiaki Tamura <address@hidden> writes:
> This fixes the following scenario using QMP.
>
> First, put a bogus argument "foo" to "type", which results in an error.
> {"execute": "netdev_add", "arguments": { "type": "foo", "id": "netdev1" } }
> Then, call it again with correct argument "user".
> {"execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
> This results in "DuplicatedId" error.
>
> Because the first command was invalid, it should be able to reuse the
> same "id", and the second command should work.
>
> Reported-by: Luiz Capitulino <address@hidden>
> Signed-off-by: Yoshiaki Tamura <address@hidden>
Looks good.