[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/23] qdev: Drop ID matching from qtree path
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/23] qdev: Drop ID matching from qtree paths |
Date: |
Wed, 23 Jun 2010 10:55:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
[cc: kraxel]
Jan Kiszka <address@hidden> writes:
> From: Jan Kiszka <address@hidden>
>
> Device IDs may conflict with device names or aliases. From now on we
> only accept them outside qtree paths. This also makes dumping IDs in
> qbus_list_dev/bus obsolete.
>
> Signed-off-by: Jan Kiszka <address@hidden>
I don't like this at all.
1. Specific problem:
With the current code, multiple devices with the same driver work
only if I take care: addressing by driver name gets me only the
first, so I better set suitable IDs.
With your patch, multiple devices with the same driver don't work, no
matter what I do.
2. General principle:
When I set an ID, I want the system to accept that ID in all contexts
where it makes sense. Ambiguity created by badly chosen IDs is *my*
problem.
[Qemu-devel] [PATCH v4 06/23] qdev: Push QMP mode checks into qbus_list_bus/dev, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 05/23] qdev: Convert device and bus lists to QTAILQ, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 08/23] qdev: Introduce qdev_iterate_recursive, Jan Kiszka, 2010/06/15