[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a boo
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool |
Date: |
Wed, 23 Jun 2010 18:31:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Wed, 23 Jun 2010 17:05:02 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>>
>> > Historically, user monitor arguments beginning with '-' (eg. '-f')
>> > were passed as integers down to handlers.
>> >
>> > I've maintained this behavior in the new monitor because we didn't
>> > have a boolean type at the very beginning of QMP. Today we have it
>> > and this behavior is causing trouble to QMP's argument checker.
>> >
>> > This commit fixes the problem by doing the following changes:
>> >
>> > 1. User Monitor
>> >
>> > Before: the optional arg was represented as a QInt, we'd pass 1
>> > down to handlers if the user specified the argument or
>> > 0 otherwise
>> >
>> > This commit: the optional arg is represented as a QBool, we pass
>> > true down to handlers if the user specified the
>> > argument, otherwise _nothing_ is passed
>> >
>> > 2. QMP
>> >
>> > Before: the client was required to pass the arg as QBool, but we'd
>> > convert it to QInt internally. If the argument wasn't passed,
>> > we'd pass 0 down
>> >
>> > This commit: still require a QBool, but doesn't do any conversion and
>> > doesn't pass any default value
>> >
>> > 3. Convert existing handlers (do_eject()/do_migrate()) to the new way
>> >
>> > Before: Both handlers would expect a QInt value, either 0 or 1
>> >
>> > This commit: Change the handlers to accept a QBool, they handle the
>> > following cases:
>> >
>> > A) true is passed: the option is enabled
>> > B) false is passed: the option is disabled
>> > C) nothing is passed: option not specified, use
>> > default behavior
>>
>> Because the user monitor can't pass false, the only sensible default
>> behavior is "disabled".
>
> Yes, but I think we shouldn't impose it. I mean, handlers are still free
> to choose an 'enabled' default state.
They are. Renders the option entirely useless in the user monitor,
though.
I don't want you to change anything, I just wanted to point out that the
human monitor can't yet support boolean arguments defaulting to true.
QMP can, of course.
- [Qemu-devel] [PATCH 03/13] QDict: Introduce functions to retrieve QDictEntry values, (continued)
- [Qemu-devel] [PATCH 03/13] QDict: Introduce functions to retrieve QDictEntry values, Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 02/13] QDict: Small terminology change, Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 05/13] check-qdict: Introduce test for the new iteration API, Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 04/13] QDict: Introduce new iteration API, Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 11/13] QError: Introduce QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER, Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 10/13] QMP: Drop old client argument checker, Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 08/13] QMP: New argument checker (first part), Luiz Capitulino, 2010/06/22
- [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool, Luiz Capitulino, 2010/06/22
[Qemu-devel] [PATCH 13/13] QMP: Drop old input object checking, Luiz Capitulino, 2010/06/22
[Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part), Luiz Capitulino, 2010/06/22
[Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj(), Luiz Capitulino, 2010/06/22